Illirgway
e0cc1ce679
Fix bug with unused (replaced with "") CONSUL_HTTP_AUTH in some places
...
example: https://github.com/hashicorp/consul/blob/master/watch/plan.go#L26
conf := consulapi.DefaultConfig()
conf.Address = address
conf.Datacenter = p.Datacenter
conf.Token = p.Token # <-- replace Token from DefaultConfig/CONSUL_HTTP_AUTH with ""
client, err := consulapi.NewClient(conf)
how to reproduce bug:
0. consul -> localhost:8500 with more than 0 service checks
1. deny all for anonymous token
2. create appropriate acl <token> for watch checks (agent:read + node:read,service:read)
3. bash:
CONSUL_HTTP_AUTH=<token> consul watch -http-addr=localhost:8500 -type=checks # --> return []
consul watch -http-addr=localhost:8500 -type=checks -token=<token> # -> return { .... right json result .... }
2017-08-16 01:51:18 +03:00
James Phillips
8d0a048408
Expands and rework context support in the API client. ( #3273 )
2017-07-14 17:30:08 -07:00
Preetha Appan
9eaf56bfe3
Fix socket file handle leaks from old blocking queries upon consul reload. This fixes issue #3018
2017-06-26 15:52:03 -05:00
James Phillips
3baa703d02
Merge pull request #3077 from jwasinger/issue-2850
...
Prevent Session.Destroy from leaving open TCP connections
2017-06-02 21:43:55 -07:00
Jared Wasinger
d2ef61d079
Prevent Session.Destroy from leaving open TCP connections
2017-05-25 20:51:27 -07:00
Kyle Havlovitz
4e44db87e3
Don't overwrite Transport's TLS config if it's been set
2017-05-24 13:45:19 -07:00
Kyle Havlovitz
04f1ff78f8
Remove superfluous default HttpClient check in NewClient
2017-05-24 11:40:21 -07:00
Frank Schroeder
3e00e36f41
golint: Untangle if blocks with return in else
2017-04-25 09:26:13 -07:00
Kyle Havlovitz
c6d0b4cf90
Make the API client's httpClient more pluggable ( #2926 )
2017-04-18 16:39:23 -07:00
Kyle Havlovitz
ae6bf56ee1
Add tls client options to api/cli
2017-04-14 13:37:29 -07:00
Jeff Mitchell
44733caf5c
Update unix dial functions to use DialContext with new go-cleanhttp
2017-02-10 21:11:21 -05:00
Kyle Havlovitz
c9abafab92
Update docs and give better error for unknown client scheme
2017-02-10 19:55:54 -05:00
Kyle Havlovitz
a7a6ee9f4c
Allow prefixing -http-addr with http/https schemes
2017-02-10 18:25:46 -05:00
Kyle Havlovitz
bad037fb58
Cleanup and formatting adjustments
2017-02-09 20:49:17 -05:00
Kyle Havlovitz
abdf1fbab3
Convert keyring command to use base.Command
2017-02-08 18:25:47 -05:00
Kyle Havlovitz
87c0283bb1
Update client api and docs for node metadata
2017-01-11 19:28:58 -05:00
James Phillips
c744792fc4
Merge pull request #2238 from hasyimibhar/master
...
Remove duplicated environment variables
2016-11-17 16:18:02 -08:00
James Phillips
9f7a973ace
Adds an `X-Consul-Translate-Addresses` to signal translation is enabled.
2016-08-16 11:31:41 -07:00
Hasyimi Bahrudin
105cea9bae
Add api environment variables as constants for consistency
2016-08-03 14:40:31 +08:00
Hasyimi Bahrudin
bb6bb19aad
Remove redundant hardcoded environment variables
...
The following hardcoded environment variables are removed:
* CONSUL_RPC_ADDR
* CONSUL_HTTP_ADDR
2016-08-03 14:40:26 +08:00
Jeff Mitchell
f1a67836d8
Use header to send Consul token rather than query param.
2016-08-02 16:54:59 -04:00
James Phillips
0eb6279c5e
Improves the comment for the Address field.
2016-03-24 11:33:44 -07:00
James Phillips
1cfed981b3
Adds TLS config helper to API client.
2016-03-24 11:24:18 -07:00
James Phillips
abacccd6e5
Switches default for API client to pooled connections.
2016-03-10 12:29:50 -08:00
James Phillips
58fb27e70f
Factors server error checking into a new function.
2016-01-06 11:35:16 -08:00
James Phillips
c048c5aca6
Makes the API behave better with small wait values.
2016-01-06 11:05:11 -08:00
James Phillips
ebff3fe0d0
Builds the insecure SSL transport off the clean default transport.
2015-12-17 12:15:18 -08:00
Jeff Mitchell
4604af6aa5
Revert "Adds client and transport pooling in the API so we don't leak connections."
2015-12-17 10:56:50 -05:00
James Phillips
f6546a0e46
Makes the insecure transport work like the default one.
2015-12-17 06:48:18 -08:00
James Phillips
d57e60a123
Adds client and transport pooling in the API so we don't leak connections.
2015-12-16 22:27:07 -08:00
James Phillips
787f946f8d
Adds support for coordinates to client API.
2015-10-23 15:23:01 -07:00
Jeff Mitchell
1e3840b044
Update cleanhttp repo location
2015-10-22 14:14:22 -04:00
Jeff Mitchell
9a5fd5424a
Use cleanhttp to get rid of DefaultTransport
2015-10-22 10:47:50 -04:00
Jeff Mitchell
f49fc095ef
Don't use http.DefaultClient
...
Two of the changes are in tests; the one of consequence is in the API.
As explained in #1308 this can cause conflicts with downstream programs.
Fixes #1308 .
2015-10-15 17:49:35 -04:00
Dale Wijnand
5a28ebcaa3
Fix a bunch of typos.
2015-09-15 13:22:08 +01:00
Seth Vargo
b4f8c98fbb
Read select environment variables when generating the default configuration
2015-03-18 11:12:10 -04:00
Armon Dadgar
5f627fca1b
api: Refactoring into shared write logic
2015-02-18 15:15:02 -08:00
Armon Dadgar
c0c9fb58ce
api: Refactoring into shared query logic
2015-02-18 15:15:02 -08:00
Ryan Uber
b30af9536d
Merge pull request #608 from imkira/fixBodyLeak
...
fixed: body not closed for non HTTP 200 responses
2015-01-19 09:33:06 -08:00
Mário Freitas
f45105383c
fixed: requireOK should close Body on error
2015-01-19 11:53:21 +09:00
Ryan Uber
4675cdf01c
agent: beginning refactor
2015-01-16 00:45:03 -08:00
Jeff Mitchell
9fcea08dbb
Ensure a socket is created for permissions adjustment tests and fix some
...
items pointed out in the code review
This code is copyright 2014 Akamai Technologies, Inc. <opensource@akamai.com>
2015-01-15 14:33:44 +00:00
Jeff Mitchell
11a3ce0bdd
RPC and HTTP interfaces fully generically-sockified so Unix is supported.
...
Client works for RPC; will honor CONSUL_RPC_ADDR. HTTP works via consul/api;
honors CONSUL_HTTP_ADDR.
The format of a Unix socket in configuration data is:
"unix://[/path/to/socket];[username or uid];[gid];[mode]"
Obviously, the user must have appropriate permissions to create the socket
file in the given path and assign the requested uid/gid. Also note that Go does
not support gid lookups from group name, so gid must be numeric. See
https://codereview.appspot.com/101310044
When connecting from the client, the format is just the first part of the
above line:
"unix://[/path/to/socket]"
This code is copyright 2014 Akamai Technologies, Inc. <opensource@akamai.com>
2015-01-14 19:31:21 +00:00
Ryan Uber
60ebd63760
Import HTTP basic auth patch from armon/consul-api#16
2015-01-07 13:01:44 -08:00
Ryan Uber
5555e0eb9b
api: initial import from armon/consul-api
2015-01-06 10:40:00 -08:00