mirror of https://github.com/status-im/consul.git
add Timeout field to CheckMonitor
This commit is contained in:
parent
963916e990
commit
fe4107019e
|
@ -968,6 +968,7 @@ func (a *Agent) AddCheck(check *structs.HealthCheck, chkType *CheckType, persist
|
|||
CheckID: check.CheckID,
|
||||
Script: chkType.Script,
|
||||
Interval: chkType.Interval,
|
||||
Timeout: chkType.Timeout,
|
||||
Logger: a.logger,
|
||||
ReapLock: &a.reapLock,
|
||||
}
|
||||
|
|
|
@ -101,6 +101,7 @@ type CheckMonitor struct {
|
|||
CheckID string
|
||||
Script string
|
||||
Interval time.Duration
|
||||
Timeout time.Duration
|
||||
Logger *log.Logger
|
||||
ReapLock *sync.RWMutex
|
||||
|
||||
|
@ -180,7 +181,11 @@ func (c *CheckMonitor) check() {
|
|||
errCh <- cmd.Wait()
|
||||
}()
|
||||
go func() {
|
||||
time.Sleep(30 * time.Second)
|
||||
if c.Timeout > 0 {
|
||||
time.Sleep(c.Timeout)
|
||||
} else {
|
||||
time.Sleep(30 * time.Second)
|
||||
}
|
||||
errCh <- fmt.Errorf("Timed out running check '%s'", c.Script)
|
||||
}()
|
||||
err = <-errCh
|
||||
|
|
|
@ -82,6 +82,36 @@ func TestCheckMonitor_BadCmd(t *testing.T) {
|
|||
expectStatus(t, "foobarbaz", structs.HealthCritical)
|
||||
}
|
||||
|
||||
func TestCheckMonitor_Timeout(t *testing.T) {
|
||||
mock := &MockNotify{
|
||||
state: make(map[string]string),
|
||||
updates: make(map[string]int),
|
||||
output: make(map[string]string),
|
||||
}
|
||||
check := &CheckMonitor{
|
||||
Notify: mock,
|
||||
CheckID: "foo",
|
||||
Script: "sleep 1 && exit 0",
|
||||
Interval: 10 * time.Millisecond,
|
||||
Timeout: 5 * time.Millisecond,
|
||||
Logger: log.New(os.Stderr, "", log.LstdFlags),
|
||||
ReapLock: &sync.RWMutex{},
|
||||
}
|
||||
check.Start()
|
||||
defer check.Stop()
|
||||
|
||||
time.Sleep(50 * time.Millisecond)
|
||||
|
||||
// Should have at least 2 updates
|
||||
if mock.updates["foo"] < 2 {
|
||||
t.Fatalf("should have at least 2 updates %v", mock.updates)
|
||||
}
|
||||
|
||||
if mock.state["foo"] != "critical" {
|
||||
t.Fatalf("should be critical %v", mock.state)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCheckMonitor_RandomStagger(t *testing.T) {
|
||||
mock := &MockNotify{
|
||||
state: make(map[string]string),
|
||||
|
|
Loading…
Reference in New Issue