status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-19 17:14:37 +00:00
Code Issues Projects Releases Wiki Activity

proxycfg: fix goroutine leak when service is re-registered (#14988)

Browse Source 
Fixes a bug where we'd leak a goroutine in state.run when the given
context was canceled while there was a pending update.
This commit is contained in:
Dan Upton 2022-10-17 11:31:10 +01:00 committed by GitHub
parent 3a60885259
commit f8b4b41205
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
agent/proxycfg/state.go
View File

@ -317,7 +317,10 @@ func (s *state) run(ctx context.Context, snap *ConfigSnapshot) {
// This runs in another goroutine so we can't just do the send // This runs in another goroutine so we can't just do the send
// directly here as access to snap is racy. Instead, signal the main // directly here as access to snap is racy. Instead, signal the main
// loop above. // loop above.
sendCh <- struct{}{} select {
case sendCh <- struct{}{}:
case <-ctx.Done():
}
}) })
} }