status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-20 01:18:49 +00:00
Code Issues Projects Releases Wiki Activity

agent/grpc: add connection count metrics

Browse Source 
Gauge metrics are great for understanding the current state, but can somtimes hide problems
if there are many disconnect/reconnects.

This commit adds counter metrics for connections and streams to make it easier to see the
count of newly created connections and streams.
This commit is contained in:
Daniel Nephin 2020-10-15 16:40:33 -04:00
parent 5319ba02b0
commit f0ac093fef
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
agent/grpc/stats.go
View File

@ -36,7 +36,7 @@ func (c *statsHandler) HandleRPC(_ context.Context, s stats.RPCStats) {
} }
switch s.(type) { switch s.(type) {
case *stats.InHeader: case *stats.InHeader:
c.metrics.IncrCounter([]string{"grpc", label, "request"}, 1) c.metrics.IncrCounter([]string{"grpc", label, "request", "count"}, 1)
} }
} }
@ -56,6 +56,7 @@ func (c *statsHandler) HandleConn(_ context.Context, s stats.ConnStats) {
switch s.(type) { switch s.(type) {
case *stats.ConnBegin: case *stats.ConnBegin:
count = atomic.AddUint64(&c.activeConns, 1) count = atomic.AddUint64(&c.activeConns, 1)
c.metrics.IncrCounter([]string{"grpc", label, "connection", "count"}, 1)
case *stats.ConnEnd: case *stats.ConnEnd:
// Decrement! // Decrement!
count = atomic.AddUint64(&c.activeConns, ^uint64(0)) count = atomic.AddUint64(&c.activeConns, ^uint64(0))
@ -80,6 +81,7 @@ func (i *activeStreamCounter) Intercept(
) error { ) error {
count := atomic.AddUint64(&i.count, 1) count := atomic.AddUint64(&i.count, 1)
i.metrics.SetGauge([]string{"grpc", "server", "streams"}, float32(count)) i.metrics.SetGauge([]string{"grpc", "server", "streams"}, float32(count))
i.metrics.IncrCounter([]string{"grpc", "server", "stream", "count"}, 1)
defer func() { defer func() {
count := atomic.AddUint64(&i.count, ^uint64(0)) count := atomic.AddUint64(&i.count, ^uint64(0))
i.metrics.SetGauge([]string{"grpc", "server", "streams"}, float32(count)) i.metrics.SetGauge([]string{"grpc", "server", "streams"}, float32(count))

4
agent/grpc/stats_test.go
View File

@ -88,7 +88,9 @@ func TestHandler_EmitsStats(t *testing.T) {
assertDeepEqual(t, expectedGauge, sink.gaugeCalls, cmpMetricCalls) assertDeepEqual(t, expectedGauge, sink.gaugeCalls, cmpMetricCalls)
expectedCounter := []metricCall{ expectedCounter := []metricCall{
{key: []string{"testing", "grpc", "server", "request"}, val: 1}, {key: []string{"testing", "grpc", "server", "connection", "count"}, val: 1},
{key: []string{"testing", "grpc", "server", "request", "count"}, val: 1},
{key: []string{"testing", "grpc", "server", "stream", "count"}, val: 1},
} }
assertDeepEqual(t, expectedCounter, sink.incrCounterCalls, cmpMetricCalls) assertDeepEqual(t, expectedCounter, sink.incrCounterCalls, cmpMetricCalls)
} }