Add some low hanging intention tests, basically add intentions to others

1. There are various things tests that can just have intentions added
into them, like filters and such like, add intentions to these
2. Start thinking about being able to negate steps easily, which will
lead on to a cleanup of the steps

ui-v2/app/templates/dc/intentions/index.hbs

@@ -27,7 +27,7 @@
             {{/block-slot}}
             {{#block-slot 'row'}}
                 <td class="source" data-test-intention="{{item.ID}}">
-                  <a href={{href-to 'dc.intentions.edit' item.ID}}>
+                  <a href={{href-to 'dc.intentions.edit' item.ID}} data-test-intention-source="{{item.SourceName}}">
                     {{#if (eq item.SourceName '*') }}
                       All Services (*)
                     {{else}}
@@ -35,10 +35,10 @@
                     {{/if}}
                   </a>
                 </td>
-                <td class="intent-{{item.Action}}">
+                <td class="intent-{{item.Action}}" data-test-intention-action="{{item.Action}}">
                     <strong>{{item.Action}}</strong>
                 </td>
-                <td class="destination">
+                <td class="destination" data-test-intention-destination="{{item.DestinationName}}">
                     {{#if (eq item.DestinationName '*') }}
                       All Services (*)
                     {{else}}

ui-v2/tests/acceptance/components/acl-filter.feature

@@ -1,5 +1,5 @@
 @setupApplicationTest
-Feature: dc / components /acl filter: Acl Filter
+Feature: components / acl filter: Acl Filter
   In order to find the acl token I'm looking for easier
   As a user
   I should be able to filter by type and freetext search tokens by name and token

ui-v2/tests/acceptance/components/intention-filter.feature

@@ -0,0 +1,55 @@
+@setupApplicationTest
+Feature: components / intention filter: Intention Filter
+  In order to find the intention I'm looking for easier
+  As a user
+  I should be able to filter by 'policy' (allow/deny) and freetext search tokens by source and destination
+  Scenario: Filtering [Model]
+    Given 1 datacenter model with the value "dc-1"
+    And 2 [Model] models
+    When I visit the [Page] page for yaml
+    ---
+      dc: dc-1
+    ---
+    Then the url should be [Url]
+
+    Then I see 2 [Model] models
+    And I see allIsSelected on the filter
+
+    When I click allow on the filter
+    Then I see allowIsSelected on the filter
+    And I see 1 [Model] model
+    And I see 1 [Model] model with the action "allow"
+
+    When I click deny on the filter
+    Then I see denyIsSelected on the filter
+    And I see 1 [Model] model
+    And I see 1 [Model] model with the action "deny"
+
+    When I click all on the filter
+    Then I see 2 [Model] models
+    Then I see allIsSelected on the filter
+    Then I fill in with yaml
+    ---
+    s: alarm
+    ---
+    And I see 1 [Model] model
+    And I see 1 [Model] model with the source "alarm"
+    Then I fill in with yaml
+    ---
+    s: feed
+    ---
+    And I see 1 [Model] model
+    And I see 1 [Model] model with the destination "feed"
+    Then I fill in with yaml
+    ---
+    s: transmitter
+    ---
+    And I see 2 [Model] models
+    And I see 1 [Model] model with the source "transmitter"
+    And I see 1 [Model] model with the destination "transmitter"
+
+  Where:
+    ---------------------------------------------
+    | Model     | Page       | Url              |
+    | intention | intentions | /dc-1/intentions |
+    ---------------------------------------------

ui-v2/tests/acceptance/components/text-input.feature

@@ -1,5 +1,5 @@
 @setupApplicationTest
-Feature: Text input
+Feature: components / text-input: Text input
   Background:
     Given 1 datacenter model with the value "dc-1"
   Scenario:

ui-v2/tests/acceptance/page-navigation.feature

@@ -16,13 +16,14 @@ Feature: Page Navigation
     When I click [Link] on the navigation
     Then the url should be [Url]
   Where:
-    --------------------------------------
+    ----------------------------------------
-    | Link     | Url                     |
+    | Link       | Url                     |
-    | nodes    | /dc-1/nodes             |
+    | nodes      | /dc-1/nodes             |
-    | kvs      | /dc-1/kv                |
+    | kvs        | /dc-1/kv                |
-    | acls     | /dc-1/acls              |
+    | acls       | /dc-1/acls              |
-    | settings | /settings               |
+    | intentions | /dc-1/intentions        |
-    --------------------------------------
+    | settings   | /settings               |
+    ----------------------------------------
   Scenario: Clicking a [Item] in the [Model] listing
     When I visit the [Model] page for yaml
     ---
@@ -31,13 +32,14 @@ Feature: Page Navigation
     When I click [Item] on the [Model]
     Then the url should be [Url]
   Where:
-    --------------------------------------------------------
+    -------------------------------------------------------------------------------------
-    | Item     | Model    | Url                            |
+    | Item      | Model      | Url                                                      |
-    | service  | services | /dc-1/services/service-0       |
+    | service   | services   | /dc-1/services/service-0                                 |
-    | node     | nodes    | /dc-1/nodes/node-0             |
+    | node      | nodes      | /dc-1/nodes/node-0                                       |
-    | kv       | kvs      | /dc-1/kv/necessitatibus-0/edit |
+    | kv        | kvs        | /dc-1/kv/necessitatibus-0/edit                           |
-    | acl      | acls     | /dc-1/acls/anonymous           |
+    | intention | intentions | /dc-1/intentions/ee52203d-989f-4f7a-ab5a-2bef004164ca    |
-    --------------------------------------------------------
+    | acl       | acls       | /dc-1/acls/anonymous                                     |
+    -------------------------------------------------------------------------------------
 @ignore
-  Scenario: Clicking a kv in the kvs listing, without depending on the salt ^
+  Scenario: Clicking items in the listings, without depending on the salt ^
     Then ok

ui-v2/tests/acceptance/steps/components/intention-filter-steps.js

@@ -0,0 +1,10 @@
+import steps from '../steps';
+
+// step definitions that are shared between features should be moved to the
+// tests/acceptance/steps/steps.js file
+
+export default function(assert) {
+  return steps(assert).then('I should find a file', function() {
+    assert.ok(true, this.step);
+  });
+}

ui-v2/tests/acceptance/submit-blank.feature

@@ -13,11 +13,12 @@ Feature: submit blank
     And I submit
     Then the url should be /datacenter/[Slug]/create
   Where:
-    ------------------
+    --------------------------
-    | Model   | Slug |
+    | Model     | Slug       |
-    | kv      | kv   |
+    | kv        | kv         |
-    | acl     | acls |
+    | acl       | acls       |
-    ------------------
+    | intention | intentions |
+    --------------------------
 @ignore
   Scenario: The button is disabled
     Then ok

ui-v2/tests/pages.js

@@ -9,6 +9,7 @@ import kvs from 'consul-ui/tests/pages/dc/kv/index';
 import kv from 'consul-ui/tests/pages/dc/kv/edit';
 import acls from 'consul-ui/tests/pages/dc/acls/index';
 import acl from 'consul-ui/tests/pages/dc/acls/edit';
+import intentions from 'consul-ui/tests/pages/dc/intentions/index';
 import intention from 'consul-ui/tests/pages/dc/intentions/edit';
 
 export default {
@@ -23,5 +24,6 @@ export default {
   kv,
   acls,
   acl,
+  intentions,
   intention,
 };

ui-v2/tests/pages/components/intention-filter.js

@@ -0,0 +1,9 @@
+import { triggerable } from 'ember-cli-page-object';
+import radiogroup from 'consul-ui/tests/lib/page-object/radiogroup';
+export default {
+  ...radiogroup('action', ['', 'allow', 'deny']),
+  ...{
+    scope: '[data-test-intention-filter]',
+    search: triggerable('keypress', '[name="s"]'),
+  },
+};

ui-v2/tests/pages/components/page.js

@@ -1,6 +1,6 @@
 import { clickable } from 'ember-cli-page-object';
 export default {
-  navigation: ['services', 'nodes', 'kvs', 'acls', 'docs', 'settings'].reduce(
+  navigation: ['services', 'nodes', 'kvs', 'acls', 'intentions', 'docs', 'settings'].reduce(
     function(prev, item, i, arr) {
       const key = item;
       return Object.assign({}, prev, {

ui-v2/tests/pages/dc/intentions/index.js

@@ -0,0 +1,16 @@
+import { create, visitable, collection, attribute, clickable } from 'ember-cli-page-object';
+
+import filter from 'consul-ui/tests/pages/components/intention-filter';
+export default create({
+  visit: visitable('/:dc/intentions'),
+  intentions: collection('[data-test-tabular-row]', {
+    source: attribute('data-test-intention-source', '[data-test-intention-source]'),
+    destination: attribute('data-test-intention-destination', '[data-test-intention-destination]'),
+    action: attribute('data-test-intention-action', '[data-test-intention-action]'),
+    intention: clickable('a'),
+    actions: clickable('label'),
+    delete: clickable('[data-test-delete]'),
+    confirmDelete: clickable('button.type-delete'),
+  }),
+  filter: filter,
+});

ui-v2/tests/steps.js

@@ -5,6 +5,8 @@ import getDictionary from '@hashicorp/ember-cli-api-double/dictionary';
 import pages from 'consul-ui/tests/pages';
 import api from 'consul-ui/tests/helpers/api';
 
+const dont = `( don't| shouldn't| can't)?`;
+
 const create = function(number, name, value) {
   // don't return a promise here as
   // I don't need it to wait
@@ -240,7 +242,9 @@ export default function(assert) {
 
         assert.equal(len, num, `Expected ${num} ${model}s, saw ${len}`);
       })
-      .then(['I see $num $model model with the $property "$value"'], function(
+      // TODO: I${ dont } see
+      .then([`I see $num $model model[s]? with the $property "$value"`], function(
+        // negate,
         num,
         model,
         property,