Apply suggestions from code review

Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
This commit is contained in:
Jeff Boruszak 2022-09-30 09:52:53 -05:00 committed by GitHub
parent 10cfc9bbb4
commit ebc069aeb6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -174,7 +174,7 @@ definition](/docs/connect/registration/service-registration) or
The [Advanced Configuration](#advanced-configuration) section describes additional configurations that allow incremental or complete control over the bootstrap configuration generated. The [Advanced Configuration](#advanced-configuration) section describes additional configurations that allow incremental or complete control over the bootstrap configuration generated.
### Bootstrap Consul on Windows VMs ### Bootstrap Envoy on Windows VMs
If you are running Consul on a Windows VM, attempting to bootstrap Envoy with the `consul connect envoy` command returns the following output: If you are running Consul on a Windows VM, attempting to bootstrap Envoy with the `consul connect envoy` command returns the following output:
@ -191,7 +191,7 @@ First, add the `-bootstrap` option to the command and save the output to a file:
$ consul connect envoy -bootstrap > bootstrap.json $ consul connect envoy -bootstrap > bootstrap.json
``` ```
Then, open `bootstrap.json` and add your ACL token and log path to the file. Then, open `bootstrap.json` and update the following sections with your ACL token and log path.
<CodeBlockConfig filename="bootstrap.json" hideClipboard lineNumbers highlight="2,19"> <CodeBlockConfig filename="bootstrap.json" hideClipboard lineNumbers highlight="2,19">
```json ```json
@ -226,7 +226,7 @@ Then, open `bootstrap.json` and add your ACL token and log path to the file.
To complete the bootstrap process, start Envoy and include the path to `bootstrap.json`: To complete the bootstrap process, start Envoy and include the path to `bootstrap.json`:
```shell-session ```shell-session
envoy -c bootstrap.json $ envoy -c bootstrap.json
``` ```
~> **Security Note**: The bootstrap JSON contains the ACL token and should be handled as a secret. Because this token authorizes the identity of any service it has `service:write` permissions for, it can be used to access upstream services. ~> **Security Note**: The bootstrap JSON contains the ACL token and should be handled as a secret. Because this token authorizes the identity of any service it has `service:write` permissions for, it can be used to access upstream services.