ci: fail cherrypick if git push fails (#9673)

This commit is contained in:
Alvin Huang 2021-01-29 19:42:14 -05:00 committed by GitHub
parent 504aa7c5fe
commit e889f7dbcd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions

View File

@ -51,8 +51,8 @@ function cherry_pick_with_slack_notification {
local pr_url="$3"
git checkout "$branch" || exit 1
# If git cherry-pick fails, we send a failure notification
if ! git cherry-pick --mainline 1 "$commit"; then
# If git cherry-pick fails or it fails to push, we send a failure notification
if ! (git cherry-pick --mainline 1 "$commit" && git push origin "$branch"); then
status "🍒❌ Cherry pick of commit ${commit:0:7} from $pr_url onto $branch failed!"
# send slack notification
@ -85,8 +85,6 @@ function cherry_pick_with_slack_notification {
# Else we send a success notification
else
status "🍒✅ Cherry picking of PR commit ${commit:0:7} from ${pr_url} succeeded!"
# push changes to the specified branch
git push origin "$branch"
curl -X POST -H 'Content-type: application/json' \
--data \
"{ \