status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

NET-6900: stop reconciling services when peering is enabled (#19907) 

stop reconciling services when peering is enabled
This commit is contained in:
Tyler Wendlandt 2023-12-12 07:36:35 -07:00 committed by GitHub
parent f2b26ac194
commit e8164c7c04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/19907.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
ui: stop manually reconciling services if peering is enabled
```

11
ui/packages/consul-ui/app/services/repository.js
View File

@ -113,6 +113,17 @@ export default class RepositoryService extends Service {
return false;
}
}
// We were seeing issues where services were all being unloaded after visiting
// a peers imported services page. So if you viewes services -> peered imported services -> services
// only the peered services would remain as the others were all unloaded. Not certain if
// we should be doing any manual reconciling as it is. Not enough historical context
// to determine that at this time.
//
// https://hashicorp.atlassian.net/browse/NET-6900
if (this.env.var('CONSUL_PEERINGS_ENABLED') && this.getModelName() === 'service') {
return false;
}
return true;
}