From dd2b3919e9a9dbfdd8c87dbc52ea1bd3a3db6d38 Mon Sep 17 00:00:00 2001
From: John Cowen <johncowen@users.noreply.github.com>
Date: Thu, 17 Dec 2020 15:26:48 +0000
Subject: [PATCH] ui: Show the No Dependencies message when a Topology has no
 streams (#9413)

Also changes the upstreams docs link
---
 .../templates/dc/services/show/topology.hbs   | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/ui/packages/consul-ui/app/templates/dc/services/show/topology.hbs b/ui/packages/consul-ui/app/templates/dc/services/show/topology.hbs
index efc0b14008..5998ffade4 100644
--- a/ui/packages/consul-ui/app/templates/dc/services/show/topology.hbs
+++ b/ui/packages/consul-ui/app/templates/dc/services/show/topology.hbs
@@ -1,24 +1,7 @@
 <EventSource @src={{topology}} />
-<div id="topology" class="tab-section">
+<div class="tab-section">
   <div role="tabpanel">
-  {{#if topology.FilteredByACLs}}
-    <TopologyMetrics::Notice::LimitedAccess />
-  {{/if}}
-  {{#if topology}}
-    <TopologyMetrics
-      @nspace={{nspace}}
-      @dc={{dc.Name}}
-      @service={{items.firstObject}}
-      @topology={{topology}}
-      @metricsHref={{render-template urls.service (hash
-        Datacenter=dc.Name
-        Service=items.firstObject
-      )}}
-      @isRemoteDC={{isRemoteDC}}
-      @hasMetricsProvider={{hasMetricsProvider}}
-      @oncreate={{route-action 'createIntention'}}
-    />
-  {{else}}
+  {{#if (and (eq topology.Upstreams.length 0) (eq topology.Downstreams.length 0))}}
     <EmptyState>
       <BlockSlot @name="header">
         <h2>
@@ -32,10 +15,27 @@
       </BlockSlot>
       <BlockSlot @name="actions">
         <li class="docs-link">
-          <a href="{{env 'CONSUL_DOCS_URL'}}/connect/registration/service-registration#upstream-configuration-reference" rel="noopener noreferrer" target="_blank">Documentation on upstreams</a>
+          <a href="{{env 'CONSUL_DOCS_URL'}}/connect/registration/service-registration#complete-configuration-example" rel="noopener noreferrer" target="_blank">Documentation on upstreams</a>
         </li>
       </BlockSlot>
     </EmptyState>
+  {{else}}
+    {{#if topology.FilteredByACLs}}
+      <TopologyMetrics::Notice::LimitedAccess />
+    {{/if}}
+    <TopologyMetrics
+      @nspace={{nspace}}
+      @dc={{dc.Name}}
+      @service={{items.firstObject}}
+      @topology={{topology}}
+      @metricsHref={{render-template urls.service (hash
+        Datacenter=dc.Name
+        Service=items.firstObject
+      )}}
+      @isRemoteDC={{isRemoteDC}}
+      @hasMetricsProvider={{hasMetricsProvider}}
+      @oncreate={{route-action 'createIntention'}}
+    />
   {{/if}}
   </div>
 </div>