From c56f03988407813bab3be1cbef6a31fb8bd978a9 Mon Sep 17 00:00:00 2001 From: Sean Chittenden Date: Mon, 28 Mar 2016 14:53:29 -0700 Subject: [PATCH] Teach fauxConnPool to fail a pct of the time 50% failure rate seems legit as a starting point w/ 100 servers. --- consul/server_manager/server_manager_test.go | 23 +++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/consul/server_manager/server_manager_test.go b/consul/server_manager/server_manager_test.go index fcfd38bafc..25673140a4 100644 --- a/consul/server_manager/server_manager_test.go +++ b/consul/server_manager/server_manager_test.go @@ -4,6 +4,7 @@ import ( "bytes" "fmt" "log" + "math/rand" "os" "strings" "testing" @@ -27,10 +28,17 @@ func GetBufferedLogger() *log.Logger { } type fauxConnPool struct { + // failPct between 0.0 and 1.0 == pct of time a Ping should fail + failPct float64 } -func (s *fauxConnPool) PingConsulServer(server *server_details.ServerDetails) (bool, error) { - return true, nil +func (cp *fauxConnPool) PingConsulServer(server *server_details.ServerDetails) (bool, error) { + var success bool + successProb := rand.Float64() + if successProb > cp.failPct { + success = true + } + return success, nil } type fauxSerf struct { @@ -48,6 +56,14 @@ func testServerManager() (sm *server_manager.ServerManager) { return sm } +func testServerManagerFailProb(failPct float64) (sm *server_manager.ServerManager) { + logger := GetBufferedLogger() + logger = log.New(os.Stderr, "", log.LstdFlags) + shutdownCh := make(chan struct{}) + sm = server_manager.New(logger, shutdownCh, &fauxSerf{}, &fauxConnPool{failPct: failPct}) + return sm +} + // func (sm *ServerManager) AddServer(server *server_details.ServerDetails) { func TestServerManager_AddServer(t *testing.T) { sm := testServerManager() @@ -209,7 +225,8 @@ func TestServerManager_NumServers(t *testing.T) { // func (sm *ServerManager) RebalanceServers() { func TestServerManager_RebalanceServers(t *testing.T) { - sm := testServerManager() + const failPct = 0.5 + sm := testServerManagerFailProb(failPct) const maxServers = 100 const numShuffleTests = 100 const uniquePassRate = 0.5