From c4a4b9df345b929dafc45ab91040a6be85d5b061 Mon Sep 17 00:00:00 2001
From: Armon Dadgar <armon.dadgar@gmail.com>
Date: Mon, 9 Dec 2013 15:29:44 -0800
Subject: [PATCH] consul: type safe event handlers

---
 consul/serf.go | 64 ++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 62 insertions(+), 2 deletions(-)

diff --git a/consul/serf.go b/consul/serf.go
index 64bfc0c877..7aedd2be4f 100644
--- a/consul/serf.go
+++ b/consul/serf.go
@@ -1,11 +1,27 @@
 package consul
 
+import (
+	"github.com/hashicorp/serf/serf"
+)
+
 // lanEventHandler is used to handle events from the lan Serf cluster
 func (s *Server) lanEventHandler() {
 	for {
 		select {
 		case e := <-s.eventChLAN:
-			s.logger.Printf("[INFO] LAN Event: %v", e)
+			switch e.EventType() {
+			case serf.EventMemberJoin:
+				s.localJoin(e.(serf.MemberEvent))
+			case serf.EventMemberLeave:
+				s.localLeave(e.(serf.MemberEvent))
+			case serf.EventMemberFailed:
+				s.localFailed(e.(serf.MemberEvent))
+			case serf.EventUser:
+				s.localEvent(e.(serf.UserEvent))
+			default:
+				s.logger.Printf("[WARN] Unhandled LAN Serf Event: %#v", e)
+			}
+
 		case <-s.shutdownCh:
 			return
 		}
@@ -17,9 +33,53 @@ func (s *Server) wanEventHandler() {
 	for {
 		select {
 		case e := <-s.eventChWAN:
-			s.logger.Printf("[INFO] WAN Event: %v", e)
+			switch e.EventType() {
+			case serf.EventMemberJoin:
+				s.remoteJoin(e.(serf.MemberEvent))
+			case serf.EventMemberLeave:
+				s.remoteLeave(e.(serf.MemberEvent))
+			case serf.EventMemberFailed:
+				s.remoteFailed(e.(serf.MemberEvent))
+			case serf.EventUser:
+				s.remoteEvent(e.(serf.UserEvent))
+			default:
+				s.logger.Printf("[WARN] Unhandled LAN Serf Event: %#v", e)
+			}
+
 		case <-s.shutdownCh:
 			return
 		}
 	}
 }
+
+// localJoin is used to handle join events on the lan serf cluster
+func (s *Server) localJoin(me serf.MemberEvent) {
+}
+
+// localLeave is used to handle leave events on the lan serf cluster
+func (s *Server) localLeave(me serf.MemberEvent) {
+}
+
+// localFailed is used to handle fail events on the lan serf cluster
+func (s *Server) localFailed(me serf.MemberEvent) {
+}
+
+// localEvent is used to handle events on the lan serf cluster
+func (s *Server) localEvent(ue serf.UserEvent) {
+}
+
+// remoteJoin is used to handle join events on the wan serf cluster
+func (s *Server) remoteJoin(me serf.MemberEvent) {
+}
+
+// remoteLeave is used to handle leave events on the wan serf cluster
+func (s *Server) remoteLeave(me serf.MemberEvent) {
+}
+
+// remoteFailed is used to handle fail events on the wan serf cluster
+func (s *Server) remoteFailed(me serf.MemberEvent) {
+}
+
+// remoteEvent is used to handle events on the wan serf cluster
+func (s *Server) remoteEvent(ue serf.UserEvent) {
+}