status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Adds a note about updating sessions after they are created.

This commit is contained in:
James Phillips 2015-10-09 08:00:34 -07:00
parent 87bb81ba4c
commit c3513b1661
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
consul/state/state_store.go
View File

@ -1492,6 +1492,13 @@ func (s *StateStore) SessionCreate(idx uint64, sess *structs.Session) error {
tx := s.db.Txn(true) tx := s.db.Txn(true)
defer tx.Abort() defer tx.Abort()
// This code is technically able to (incorrectly) update an existing
// session but we never do that in practice. The upstream endpoint code
// always adds a unique ID when doing a create operation so we never hit
// an existing session again. It isn't worth the overhead to verify
// that here, but it's worth noting that we should never do this in the
// future.
// Call the session creation // Call the session creation
if err := s.sessionCreateTxn(tx, idx, sess); err != nil { if err := s.sessionCreateTxn(tx, idx, sess); err != nil {
return err return err