status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #608 from imkira/fixBodyLeak 

fixed: body not closed for non HTTP 200 responses
This commit is contained in:
Ryan Uber 2015-01-19 09:33:06 -08:00
parent 72109ecee1 f45105383c
commit b30af9536d
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
api/api.go
View File

@ -336,12 +336,16 @@ func encodeBody(obj interface{}) (io.Reader, error) {
// requireOK is used to wrap doRequest and check for a 200 // requireOK is used to wrap doRequest and check for a 200
func requireOK(d time.Duration, resp *http.Response, e error) (time.Duration, *http.Response, error) { func requireOK(d time.Duration, resp *http.Response, e error) (time.Duration, *http.Response, error) {
if e != nil { if e != nil {
return d, resp, e if resp != nil {
resp.Body.Close()
}
return d, nil, e
} }
if resp.StatusCode != 200 { if resp.StatusCode != 200 {
var buf bytes.Buffer var buf bytes.Buffer
io.Copy(&buf, resp.Body) io.Copy(&buf, resp.Body)
return d, resp, fmt.Errorf("Unexpected response code: %d (%s)", resp.StatusCode, buf.Bytes()) resp.Body.Close()
return d, nil, fmt.Errorf("Unexpected response code: %d (%s)", resp.StatusCode, buf.Bytes())
} }
return d, resp, e return d, resp, nil
} }