status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-27 04:40:41 +00:00
Code Issues Projects Releases Wiki Activity

snapshot: return the error from replyFn

Browse Source 
The only function passed to SnapshotRPC today always returns a nil error, so there's no
way to exercise this bug in practice. This change is being made for correctness so that
it doesn't become a problem in the future, if we ever pass a different function to
SnapshotRPC.
This commit is contained in:
Daniel Nephin 2021-12-23 16:56:30 -05:00
parent ff7f3a9737
commit abfc1e4840
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
agent/consul/client.go
View File

@ -347,7 +347,7 @@ func (c *Client) SnapshotRPC(args *structs.SnapshotRequest, in io.Reader, out io
// Let the caller peek at the reply. // Let the caller peek at the reply.
if replyFn != nil { if replyFn != nil {
if err := replyFn(&reply); err != nil { if err := replyFn(&reply); err != nil {
return nil return err
} }
} }

2
agent/consul/server.go
View File

@ -1347,7 +1347,7 @@ func (s *Server) SnapshotRPC(args *structs.SnapshotRequest, in io.Reader, out io
// Let the caller peek at the reply. // Let the caller peek at the reply.
if replyFn != nil { if replyFn != nil {
if err := replyFn(&reply); err != nil { if err := replyFn(&reply); err != nil {
return nil return err
} }
} }