status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Hardcode links to CCM to be false (#20732) 

Hardcode links to CCM to be false - due to CCM deprecation

Remove changelog item for breaking Ui change
 - since CCM linking no longer exists
This commit is contained in:
Chris Hut 2024-02-26 12:34:01 -08:00 committed by GitHub
parent 3ee926e6b3
commit a58f346f55
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/20474.txt
View File

@ -1,3 +0,0 @@
```release-note:breaking-change
ui: Adds a "Link to HCP Consul Central" modal with integration to side-nav and link to HCP banner. There will be an option to disable the Link to HCP banner from the UI in a follow-up release.
```

3
ui/packages/consul-ui/app/components/hcp-nav-item/index.js
View File

@ -41,7 +41,8 @@ export default class HcpLinkItemComponent extends Component {
return false; return false;
} }
return true; // With the death of Consul Central, we don't want to display the link nav item
return false;
} }
get shouldShowBackToHcpItem() { get shouldShowBackToHcpItem() {

3
ui/packages/consul-ui/app/services/hcp-link-status.js
View File

@ -14,7 +14,8 @@ export default class HcpLinkStatus extends Service {
userDismissedBanner = false; userDismissedBanner = false;
get shouldDisplayBanner() { get shouldDisplayBanner() {
return !this.userDismissedBanner && this.hasPermissionToLink; // With the death of Consul Central, we don't want to display the link nav item
return false;
} }
get hasPermissionToLink() { get hasPermissionToLink() {

2
ui/packages/consul-ui/tests/acceptance/link-to-hcp-test.js
View File

@ -12,7 +12,7 @@ const linkToHcpSelector = '[data-test-link-to-hcp]';
const linkToHcpBannerButtonSelector = '[data-test-link-to-hcp-banner-button]'; const linkToHcpBannerButtonSelector = '[data-test-link-to-hcp-banner-button]';
const linkToHcpModalSelector = '[data-test-link-to-hcp-modal]'; const linkToHcpModalSelector = '[data-test-link-to-hcp-modal]';
const linkToHcpModalCancelButtonSelector = '[data-test-link-to-hcp-modal-cancel-button]'; const linkToHcpModalCancelButtonSelector = '[data-test-link-to-hcp-modal-cancel-button]';
module('Acceptance | link to hcp', function (hooks) { module.skip('Acceptance | link to hcp', function (hooks) {
setupApplicationTest(hooks); setupApplicationTest(hooks);
hooks.beforeEach(function () { hooks.beforeEach(function () {

2
ui/packages/consul-ui/tests/integration/components/hcp-nav-item-test.js
View File

@ -86,7 +86,7 @@ module('Integration | Component | hcp nav item', function (hooks) {
}); });
}); });
module('when rendered in self managed mode', function (hooks) { module.skip('when rendered in self managed mode', function (hooks) {
hooks.beforeEach(function () { hooks.beforeEach(function () {
this.owner.register( this.owner.register(
'service:env', 'service:env',