From a37222eb0a48eaf129e3f2275838c2d02bae370e Mon Sep 17 00:00:00 2001 From: Daniel Nephin Date: Tue, 16 Feb 2021 14:39:34 -0500 Subject: [PATCH] Update contrib docs for the new test name --- contributing/checklist-adding-config-fields.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contributing/checklist-adding-config-fields.md b/contributing/checklist-adding-config-fields.md index b640024718..fff3fba368 100644 --- a/contributing/checklist-adding-config-fields.md +++ b/contributing/checklist-adding-config-fields.md @@ -39,11 +39,11 @@ There are four specific cases covered with increasing complexity: - [ ] **If** your new config field needed some validation as it's only valid in some cases or with some values (often true). - [ ] Add validation to Validate in `agent/config/builder.go`. - - [ ] Add a test case to the table test `TestConfigFlagsAndEdgeCases` in + - [ ] Add a test case to the table test `TestLoad_IntegrationWithFlags` in `agent/config/runtime_test.go`. - [ ] **If** your new config field needs a non-zero-value default. - [ ] Add that to `DefaultSource` in `agent/config/defaults.go`. - - [ ] Add a test case to the table test `TestConfigFlagsAndEdgeCases` in + - [ ] Add a test case to the table test `TestLoad_IntegrationWithFlags` in `agent/config/runtime_test.go`. - [ ] **If** your config should take effect on a reload/HUP. - [ ] Add necessary code to to trigger a safe (locked or atomic) update to @@ -72,7 +72,7 @@ If the config field also needs a CLI flag, then follow these steps. - [ ] Add the new flag to `agent/config/flags.go`. - [ ] Add a test case to TestParseFlags in `agent/config/flag_test.go`. - [ ] Add a test case (or extend one if appropriate) to the table test - `TestConfigFlagsAndEdgeCases` in `agent/config/runtime_test.go` to ensure setting the + `TestLoad_IntegrationWithFlags` in `agent/config/runtime_test.go` to ensure setting the flag works. - [ ] Add flag (as well as config file) documentation to `website/source/docs/agent/options.html.md`.