From 98850322c07b6b43e6af7a85a445297975549d89 Mon Sep 17 00:00:00 2001 From: James Phillips Date: Wed, 27 Sep 2017 11:59:22 -0700 Subject: [PATCH] Adds a comment about Datacenter and NodeName being stable interfaces in the runtime config strucutre. --- agent/config/runtime.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/agent/config/runtime.go b/agent/config/runtime.go index fd7f7d9570..fd8ad4744c 100644 --- a/agent/config/runtime.go +++ b/agent/config/runtime.go @@ -105,6 +105,12 @@ type RuntimeConfig struct { TelemetryStatsdAddr string TelemetryStatsiteAddr string + // Datacenter and NodeName are exposed via /v1/agent/self from here and + // used in lots of places like CLI commands. Treat this as an interface + // that must be stable. + Datacenter string + NodeName string + AdvertiseAddrLAN *net.IPAddr AdvertiseAddrWAN *net.IPAddr BindAddr *net.IPAddr @@ -119,7 +125,6 @@ type RuntimeConfig struct { DNSAddrs []net.Addr DNSPort int DataDir string - Datacenter string DevMode bool DisableAnonymousSignature bool DisableCoordinates bool @@ -144,7 +149,6 @@ type RuntimeConfig struct { LogLevel string NodeID types.NodeID NodeMeta map[string]string - NodeName string NonVotingServer bool PidFile string RPCAdvertiseAddr *net.TCPAddr