Merge pull request #1907 from hashicorp/b-empty-node-name

Node names are not allowed to be empty

command/agent/command.go

@@ -164,11 +164,16 @@ func (c *Command) readConfig() *Config {
 	if config.NodeName == "" {
 		hostname, err := os.Hostname()
 		if err != nil {
-			c.Ui.Error(fmt.Sprintf("Error determining hostname: %s", err))
+			c.Ui.Error(fmt.Sprintf("Error determining node name: %s", err))
 			return nil
 		}
 		config.NodeName = hostname
 	}
+	hostname = strings.TrimSpace(hostname)
+	if hostname == "" {
+		c.Ui.Error("Node name can not be empty")
+		return nil
+	}
 
 	// Ensure we have a data directory
 	if config.DataDir == "" && !dev {

command/agent/command_test.go

@@ -114,24 +114,43 @@ func TestReadCliConfig(t *testing.T) {
 	shutdownCh := make(chan struct{})
 	defer close(shutdownCh)
 
-	tmpDir, err := ioutil.TempDir("", "consul")
-	if err != nil {
-		t.Fatalf("err: %s", err)
+	// Test config parse
+	{
+		tmpDir, err := ioutil.TempDir("", "consul")
+		if err != nil {
+			t.Fatalf("err: %s", err)
+		}
+
+		cmd := &Command{
+			args: []string{
+				"-data-dir", tmpDir,
+				"-node", `"a"`,
+				"-advertise-wan", "1.2.3.4",
+			},
+			ShutdownCh: shutdownCh,
+			Ui:         new(cli.MockUi),
+		}
+
+		config := cmd.readConfig()
+		if config.AdvertiseAddrWan != "1.2.3.4" {
+			t.Fatalf("expected -advertise-addr-wan 1.2.3.4 got %s", config.AdvertiseAddrWan)
+		}
 	}
 
-	cmd := &Command{
-		args: []string{
-			"-data-dir", tmpDir,
-			"-node", `"a"`,
-			"-advertise-wan", "1.2.3.4",
-		},
-		ShutdownCh: shutdownCh,
-		Ui:         new(cli.MockUi),
-	}
+	// Test empty node name
+	{
+		cmd := &Command{
+			args: []string{
+				"-node", `""`,
+			},
+			ShutdownCh: shutdownCh,
+			Ui:         new(cli.MockUi),
+		}
 
-	config := cmd.readConfig()
-	if config.AdvertiseAddrWan != "1.2.3.4" {
-		t.Fatalf("expected -advertise-addr-wan 1.2.3.4 got %s", config.AdvertiseAddrWan)
+		config := cmd.readConfig()
+		if config != nil {
+			t.Errorf(`Expected -node="" to fail`)
+		}
 	}
 }