status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-18 00:27:04 +00:00
Code Issues Projects Releases Wiki Activity

Log the correlation ID when blocking queries fire (#10689)

Browse Source 
Knowing that blocking queries are firing does not provide much
information on its own. If we know the correlation IDs we can
piece together which parts of the snapshot have been populated.

Some of these responses might be empty from the blocking
query timing out. But if they're returning quickly I think we
can reasonably assume they contain data.
This commit is contained in:
Freddy 2021-07-23 16:36:17 -06:00 committed by hc-github-team-consul-core
parent 3dde24d8c9
commit 9265d20859
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/10689.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:improvement
proxycfg: log correlation IDs for the proxy configuration snapshot's blocking queries.
```

2
agent/proxycfg/state.go
View File

@ -638,7 +638,7 @@ func (s *state) run(snap *ConfigSnapshot) {
case <-s.ctx.Done():
return
case u := <-s.ch:
s.logger.Trace("A blocking query returned; handling snapshot update")
s.logger.Trace("A blocking query returned; handling snapshot update", "correlationID", u.CorrelationID)
if err := s.handleUpdate(u, snap); err != nil {
s.logger.Error("Failed to handle update from watch",