From 6682a0d4be996b70ec01095d02443bd1a9404c8e Mon Sep 17 00:00:00 2001 From: Krastin Krastev Date: Tue, 22 Mar 2022 20:36:59 +0100 Subject: [PATCH 1/2] docs: fix a trailing comma in JSON body removing a comma after a last element in JSON body --- website/content/docs/connect/registration/sidecar-service.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/content/docs/connect/registration/sidecar-service.mdx b/website/content/docs/connect/registration/sidecar-service.mdx index c08bd17916..a795d61e15 100644 --- a/website/content/docs/connect/registration/sidecar-service.mdx +++ b/website/content/docs/connect/registration/sidecar-service.mdx @@ -50,7 +50,7 @@ definitions: { "service": { "name": "web", - "port": 8080, + "port": 8080 } } { From 49ac06a51e7f6e1611ee7ec5f752256d2acd5125 Mon Sep 17 00:00:00 2001 From: Krastin Krastev Date: Mon, 18 Jul 2022 13:44:50 +0300 Subject: [PATCH 2/2] docs: clean-up expanded service def --- .../connect/registration/sidecar-service.mdx | 46 ++++++++++--------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/website/content/docs/connect/registration/sidecar-service.mdx b/website/content/docs/connect/registration/sidecar-service.mdx index a795d61e15..7021265bcf 100644 --- a/website/content/docs/connect/registration/sidecar-service.mdx +++ b/website/content/docs/connect/registration/sidecar-service.mdx @@ -48,32 +48,34 @@ definitions: ```json { - "service": { - "name": "web", - "port": 8080 - } -} -{ - "name": "web-sidecar-proxy", - "port": 20000, - "kind": "connect-proxy", - "checks": [ + "services": [ { - "Name": "Connect Sidecar Listening", - "TCP": "127.0.0.1:20000", - "Interval": "10s" + "name": "web", + "port": 8080 }, { - "name": "Connect Sidecar Aliasing web", - "alias_service": "web" + "name": "web-sidecar-proxy", + "port": 20000, + "kind": "connect-proxy", + "checks": [ + { + "Name": "Connect Sidecar Listening", + "TCP": "127.0.0.1:20000", + "Interval": "10s" + }, + { + "name": "Connect Sidecar Aliasing web", + "alias_service": "web" + } + ], + "proxy": { + "destination_service_name": "web", + "destination_service_id": "web", + "local_service_address": "127.0.0.1", + "local_service_port": 8080 + } } - ], - "proxy": { - "destination_service_name": "web", - "destination_service_id": "web", - "local_service_address": "127.0.0.1", - "local_service_port": 8080, - } + ] } ```