status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Changes to more idiomatic "ok" pattern for prefix getter.

This commit is contained in:
James Phillips 2016-02-24 16:26:43 -08:00
parent e283f9512e
commit 87ceb2f3de
4 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
consul/acl.go
View File

@ -389,9 +389,9 @@ func (f *aclFilter) filterPreparedQueries(queries *structs.PreparedQueries) {
for _, query := range *queries { for _, query := range *queries {
// If no prefix ACL applies to this query then filter it, since // If no prefix ACL applies to this query then filter it, since
// we know at this point the user doesn't have a management // we know at this point the user doesn't have a management
// token. // token, otherwise see what the policy says.
prefix := query.GetACLPrefix() prefix, ok := query.GetACLPrefix()
if prefix == nil || !f.acl.PreparedQueryRead(*prefix) { if !ok || !f.acl.PreparedQueryRead(prefix) {
f.logger.Printf("[DEBUG] consul: dropping prepared query %q from result due to ACLs", query.ID) f.logger.Printf("[DEBUG] consul: dropping prepared query %q from result due to ACLs", query.ID)
continue continue
} }

10
consul/prepared_query_endpoint.go
View File

@ -65,8 +65,8 @@ func (p *PreparedQuery) Apply(args *structs.PreparedQueryRequest, reply *string)
// If prefix ACLs apply to the incoming query, then do an ACL check. We // If prefix ACLs apply to the incoming query, then do an ACL check. We
// need to make sure they have write access for whatever they are // need to make sure they have write access for whatever they are
// proposing. // proposing.
if prefix := args.Query.GetACLPrefix(); prefix != nil { if prefix, ok := args.Query.GetACLPrefix(); ok {
if acl != nil && !acl.PreparedQueryWrite(*prefix) { if acl != nil && !acl.PreparedQueryWrite(prefix) {
p.srv.logger.Printf("[WARN] consul.prepared_query: Operation on prepared query '%s' denied due to ACLs", args.Query.ID) p.srv.logger.Printf("[WARN] consul.prepared_query: Operation on prepared query '%s' denied due to ACLs", args.Query.ID)
return permissionDeniedErr return permissionDeniedErr
} }
@ -85,8 +85,8 @@ func (p *PreparedQuery) Apply(args *structs.PreparedQueryRequest, reply *string)
return fmt.Errorf("Cannot modify non-existent prepared query: '%s'", args.Query.ID) return fmt.Errorf("Cannot modify non-existent prepared query: '%s'", args.Query.ID)
} }
if prefix := query.GetACLPrefix(); prefix != nil { if prefix, ok := query.GetACLPrefix(); ok {
if acl != nil && !acl.PreparedQueryWrite(*prefix) { if acl != nil && !acl.PreparedQueryWrite(prefix) {
p.srv.logger.Printf("[WARN] consul.prepared_query: Operation on prepared query '%s' denied due to ACLs", args.Query.ID) p.srv.logger.Printf("[WARN] consul.prepared_query: Operation on prepared query '%s' denied due to ACLs", args.Query.ID)
return permissionDeniedErr return permissionDeniedErr
} }
@ -216,7 +216,7 @@ func (p *PreparedQuery) Get(args *structs.PreparedQuerySpecificRequest,
// always allowed to see it if they have the ID. // always allowed to see it if they have the ID.
reply.Index = index reply.Index = index
reply.Queries = structs.PreparedQueries{query} reply.Queries = structs.PreparedQueries{query}
if prefix := query.GetACLPrefix(); prefix == nil { if _, ok := query.GetACLPrefix(); !ok {
return nil return nil
} }

9
consul/structs/prepared_query.go
View File

@ -73,13 +73,14 @@ type PreparedQuery struct {
} }
// GetACLPrefix returns the prefix to look up the prepared_query ACL policy for // GetACLPrefix returns the prefix to look up the prepared_query ACL policy for
// this query, or nil if such a policy doesn't apply. // this query, and whether the prefix applies to this query. You always need to
func (pq *PreparedQuery) GetACLPrefix() *string { // check the ok value before using the prefix.
func (pq *PreparedQuery) GetACLPrefix() (string, bool) {
if pq.Name != "" { if pq.Name != "" {
return &pq.Name return pq.Name, true
} }
return nil return "", false
} }
type PreparedQueries []*PreparedQuery type PreparedQueries []*PreparedQuery

6
consul/structs/prepared_query_test.go
View File

@ -6,12 +6,12 @@ import (
func TestStructs_PreparedQuery_GetACLPrefix(t *testing.T) { func TestStructs_PreparedQuery_GetACLPrefix(t *testing.T) {
ephemeral := &PreparedQuery{} ephemeral := &PreparedQuery{}
if prefix := ephemeral.GetACLPrefix(); prefix != nil { if prefix, ok := ephemeral.GetACLPrefix(); ok {
t.Fatalf("bad: %#v", prefix) t.Fatalf("bad: %s", prefix)
} }
named := &PreparedQuery{Name: "hello"} named := &PreparedQuery{Name: "hello"}
if prefix := named.GetACLPrefix(); prefix == nil || *prefix != "hello" { if prefix, ok := named.GetACLPrefix(); !ok || prefix != "hello" {
t.Fatalf("bad: %#v", prefix) t.Fatalf("bad: %#v", prefix)
} }
} }