status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-04 18:03:39 +00:00
Code Issues Projects Releases Wiki Activity

Remove Name/Namespace fields from upstream default (#11456)

Browse Source 
The UpstreamConfig.Defaults field does not support setting Name or
Namespace because the purpose is to apply defaults to all upstreams.
I think this was just missed in the docs since those fields would
error if set under Defaults.

i.e. this is not supported:

```
UpstreamConfig {
  Defaults {
    Name = "foo"
    Namespace = "bar"
    # Defaults config here
  }
}
```
This commit is contained in:
Luke Kysow 2021-11-02 14:21:15 -07:00 committed by GitHub
parent 4ddf973a31
commit 7eb32cdb73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
website/content/docs/connect/config-entries/service-defaults.mdx
View File

@ -230,6 +230,7 @@ spec:
}
}
```
</CodeTabs>
</Tab>
@ -338,14 +339,13 @@ spec:
name: 'Protocol',
type: 'string: ""',
description:
`The protocol for the upstream listener.
`The protocol for the upstream listener.<br><br>
NOTE: The protocol of a service should ideally be configured via the
[\`protocol\`](/docs/connect/config-entries/service-defaults#protocol)
field of a
[\`service-defaults\`](/docs/connect/config-entries/service-defaults)
config entry for the upstream destination service. Configuring it in a
proxy upstream config will not fully enable some
proxy upstream config will not fully enable some
[L7 features](/docs/connect/l7-traffic-management).
It is supported here for backwards compatibility with Consul versions prior to 1.6.0.
`,
@ -375,7 +375,7 @@ spec:
It is supported here for backwards compatibility with Consul versions prior to 1.6.0.
`,
},
},
},
{
name: 'MeshGateway',
type: 'MeshGatewayConfig: <optional>',
@ -454,18 +454,8 @@ spec:
{
name: 'Defaults',
type: 'UpstreamConfig: <optional>',
description: `Default configuration that applies to all upstreams of the given service.`,
description: `Default configuration that applies to all upstreams of this service.`,
children: [
{
name: 'Name',
type: 'string: ""',
description: 'The upstream name to apply the configuration to.',
},
{
name: 'Namespace',
type: 'string: ""',
description: 'The namespace of the upstream.',
},
{
name: 'Protocol',
type: 'string: ""',
@ -697,7 +687,7 @@ spec:
],
},
],
},
}
]}
/>