mirror of https://github.com/status-im/consul.git
Allow service identity tokens the ability to read jwt-providers (#17893)
* Allow service identity tokens the ability to read jwt-providers * more tests * service_prefix tests
This commit is contained in:
parent
601490b9ab
commit
767ef2dd4c
|
@ -316,6 +316,15 @@ func (e *JWTProviderConfigEntry) GetRaftIndex() *RaftIndex { retur
|
||||||
func (e *JWTProviderConfigEntry) CanRead(authz acl.Authorizer) error {
|
func (e *JWTProviderConfigEntry) CanRead(authz acl.Authorizer) error {
|
||||||
var authzContext acl.AuthorizerContext
|
var authzContext acl.AuthorizerContext
|
||||||
e.FillAuthzContext(&authzContext)
|
e.FillAuthzContext(&authzContext)
|
||||||
|
|
||||||
|
// allow service-identity tokens the ability to read jwt-providers
|
||||||
|
// this is a workaround to allow sidecar proxies to read the jwt-providers
|
||||||
|
// see issue: https://github.com/hashicorp/consul/issues/17886 for more details
|
||||||
|
err := authz.ToAllowAuthorizer().ServiceWriteAnyAllowed(&authzContext)
|
||||||
|
if err == nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
return authz.ToAllowAuthorizer().MeshReadAllowed(&authzContext)
|
return authz.ToAllowAuthorizer().MeshReadAllowed(&authzContext)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -338,6 +338,24 @@ func TestJWTProviderConfigEntry_ACLs(t *testing.T) {
|
||||||
canRead: false,
|
canRead: false,
|
||||||
canWrite: false,
|
canWrite: false,
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
name: "jwt-provider: any service write",
|
||||||
|
authorizer: newTestAuthz(t, `service "" { policy = "write" }`),
|
||||||
|
canRead: true,
|
||||||
|
canWrite: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "jwt-provider: specific service write",
|
||||||
|
authorizer: newTestAuthz(t, `service "web" { policy = "write" }`),
|
||||||
|
canRead: true,
|
||||||
|
canWrite: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "jwt-provider: any service prefix write",
|
||||||
|
authorizer: newTestAuthz(t, `service_prefix "" { policy = "write" }`),
|
||||||
|
canRead: true,
|
||||||
|
canWrite: false,
|
||||||
|
},
|
||||||
{
|
{
|
||||||
name: "jwt-provider: mesh read",
|
name: "jwt-provider: mesh read",
|
||||||
authorizer: newTestAuthz(t, `mesh = "read"`),
|
authorizer: newTestAuthz(t, `mesh = "read"`),
|
||||||
|
|
Loading…
Reference in New Issue