status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix error checking 

There were two identical if lines, remove one and use a switch/case so the compiler
can catch this problem.
This commit is contained in:
Daniel Nephin 2020-12-21 18:11:19 -05:00
parent 863551beb4
commit 76787d4dd0
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
agent/config/runtime_test.go
View File

@ -4923,16 +4923,12 @@ func testConfig(t *testing.T, tests []testCase, dataDir string) {
}
actual, err := b.BuildAndValidate()
if err == nil && tt.err != "" {
t.Fatalf("got no error want %q", tt.err)
}
if err != nil && tt.err == "" {
t.Fatalf("got error %s want nil", err)
}
if err == nil && tt.err != "" {
switch {
case err == nil && tt.err != "":
t.Fatalf("got nil want error to contain %q", tt.err)
}
if err != nil && tt.err != "" && !strings.Contains(err.Error(), tt.err) {
case err != nil && tt.err == "":
t.Fatalf("got error %s want nil", err)
case err != nil && tt.err != "" && !strings.Contains(err.Error(), tt.err):
t.Fatalf("error %q does not contain %q", err.Error(), tt.err)
}
if tt.err != "" {