From 649082ab35ccfabd72bd51f438fc1bb9598d9117 Mon Sep 17 00:00:00 2001 From: Dhi Aurrahman Date: Wed, 24 Oct 2018 21:02:01 +0700 Subject: [PATCH] connect: Fix comment DYNAMIC_DNS to LOGICAL_DNS (#4799) LOGICAL_DNS is one of the supported service discovery types [1]. [1] https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/service_discovery#arch-overview-service-discovery-types --- command/connect/envoy/envoy.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/command/connect/envoy/envoy.go b/command/connect/envoy/envoy.go index 63830ca6d5..3500b69476 100644 --- a/command/connect/envoy/envoy.go +++ b/command/connect/envoy/envoy.go @@ -213,7 +213,7 @@ func (c *cmd) templateArgs() (*templateArgs, error) { } // We use STATIC for agent which means we need to resolve DNS names like - // `localhost` ourselves. We could use STRICT_DNS or DYNAMIC_DNS with envoy + // `localhost` ourselves. We could use STRICT_DNS or LOGICAL_DNS with envoy // but Envoy resolves `localhost` differently to go on macOS at least which // causes paper cuts like default dev agent (which binds specifically to // 127.0.0.1) isn't reachable since Envoy resolves localhost to `[::]` and