From 5d77ba076ab25d28c549ffb6b69a16270efa9127 Mon Sep 17 00:00:00 2001
From: John Cowen <johncowen@users.noreply.github.com>
Date: Wed, 20 May 2020 14:09:09 +0100
Subject: [PATCH] ui: Blink/Webkit input[type=password] workaround (#7929)

It seems that blink/webkit browsers at least will leak memory when using
input[type=password] inputs. This only affects us during testing as we
'refresh' the ember app ~1000 times without actually refreshing
the browser. This means references to these HTML input elements mount
up now that every single page/test has an input[password] on it.

Following this change our memory usage during testing seems to have
reduced by as much as 75%.

During normal usage the single password element is only added to the
page once per login/logout.
---
 ui-v2/app/components/auth-form/index.hbs | 2 +-
 ui-v2/app/components/auth-form/index.js  | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ui-v2/app/components/auth-form/index.hbs b/ui-v2/app/components/auth-form/index.hbs
index 4da0b5b12e..c9ec424984 100644
--- a/ui-v2/app/components/auth-form/index.hbs
+++ b/ui-v2/app/components/auth-form/index.hbs
@@ -43,7 +43,7 @@
           <input
             {{ref this 'input'}}
             disabled={{state-matches state "loading"}}
-            type="password"
+            type={{inputType}}
             name="auth[SecretID]"
             placeholder="SecretID"
             value={{secret}}
diff --git a/ui-v2/app/components/auth-form/index.js b/ui-v2/app/components/auth-form/index.js
index c6a95e2775..7dda1779df 100644
--- a/ui-v2/app/components/auth-form/index.js
+++ b/ui-v2/app/components/auth-form/index.js
@@ -1,4 +1,6 @@
 import Component from '@ember/component';
+import { computed } from '@ember/object';
+import Ember from 'ember';
 
 import chart from './chart.xstate';
 
@@ -6,6 +8,12 @@ export default Component.extend({
   tagName: '',
   onsubmit: function(e) {},
   onchange: function(e) {},
+  // Blink/Webkit based seem to leak password inputs
+  // this will only occur during acceptance testing so
+  // turn them into text inputs during acceptance testing
+  inputType: computed(function() {
+    return Ember.testing ? 'text' : 'password';
+  }),
   init: function() {
     this._super(...arguments);
     this.chart = chart;