status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-19 17:14:37 +00:00
Code Issues Projects Releases Wiki Activity

handle error scenario of empty local DC

Browse Source
This commit is contained in:
freddygv 2021-11-08 09:26:14 -07:00
parent af29cda415
commit 5c121d7a48
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
agent/consul/config_endpoint.go
View File

@ -598,6 +598,10 @@ func gateWriteToSecondary(targetDC, localDC, primaryDC, kind string) error {
if kind != structs.PartitionExports { if kind != structs.PartitionExports {
return nil return nil
} }
if localDC == "" {
// This should not happen because the datacenter is defaulted in DefaultConfig.
return fmt.Errorf("unknown local datacenter")
}
if primaryDC == "" { if primaryDC == "" {
primaryDC = localDC primaryDC = localDC

8
agent/consul/config_endpoint_test.go
View File

@ -2151,6 +2151,14 @@ func Test_gateWriteToSecondary(t *testing.T) {
}, },
wantErr: "must target the primary datacenter explicitly", wantErr: "must target the primary datacenter explicitly",
}, },
{
name: "empty local DC",
args: args{
localDC: "",
kind: structs.PartitionExports,
},
wantErr: "unknown local datacenter",
},
} }
for _, tc := range tt { for _, tc := range tt {
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {