Merge pull request #8685 from pierresouchay/do_not_flood_logs_with_Non-server_in_server-only_area

[BUGFIX] Avoid GetDatacenter* methods to flood Consul servers logs

.changelog/8685.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+fixed a bug that caused logs to be flooded with `[WARN] agent.router: Non-server in server-only area`
+```

agent/router/router.go

@@ -536,10 +536,13 @@ func (r *Router) GetDatacentersByDistance() ([]string, error) {
 		for _, m := range info.cluster.Members() {
 			ok, parts := metadata.IsConsulServer(m)
 			if !ok {
-				r.logger.Warn("Non-server in server-only area",
+				if areaID != types.AreaLAN {
-					"non_server", m.Name,
+					r.logger.Warn("Non-server in server-only area",
-					"area", areaID,
+						"non_server", m.Name,
-				)
+						"area", areaID,
+						"func", "GetDatacentersByDistance",
+					)
+				}
 				continue
 			}
 
@@ -547,6 +550,7 @@ func (r *Router) GetDatacentersByDistance() ([]string, error) {
 				r.logger.Debug("server in area left, skipping",
 					"server", m.Name,
 					"area", areaID,
+					"func", "GetDatacentersByDistance",
 				)
 				continue
 			}
@@ -607,10 +611,13 @@ func (r *Router) GetDatacenterMaps() ([]structs.DatacenterMap, error) {
 		for _, m := range info.cluster.Members() {
 			ok, parts := metadata.IsConsulServer(m)
 			if !ok {
-				r.logger.Warn("Non-server in server-only area",
+				if areaID != types.AreaLAN {
-					"non_server", m.Name,
+					r.logger.Warn("Non-server in server-only area",
-					"area", areaID,
+						"non_server", m.Name,
-				)
+						"area", areaID,
+						"func", "GetDatacenterMaps",
+					)
+				}
 				continue
 			}
 
@@ -618,6 +625,7 @@ func (r *Router) GetDatacenterMaps() ([]structs.DatacenterMap, error) {
 				r.logger.Debug("server in area left, skipping",
 					"server", m.Name,
 					"area", areaID,
+					"func", "GetDatacenterMaps",
 				)
 				continue
 			}