status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-22 10:28:31 +00:00
Code Issues Projects Releases Wiki Activity

cleanup unit test code a bit

Browse Source
This commit is contained in:
Preetha Appan 2018-03-16 09:36:57 -05:00
parent c87699abf2
commit 2eed7766a8
No known key found for this signature in database
GPG Key ID: 9F7C19990A50EAFC
1 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
agent/http_oss_test.go
View File

@ -18,11 +18,28 @@ var extraTestEndpoints = map[string][]string{
"/v1/query/xxx/explain": []string{"GET"},
}
// certain endpoints can't be unit tested.
// These endpoints are ignored in unit testing for response codes
var ignoredEndpoints = []string{"/v1/status/peers","/v1/agent/monitor", "/v1/agent/reload" }
// These have custom logic
var customEndpoints = []string{"/v1/query", "/v1/query/"}
// includePathInTest returns whether this path should be ignored for the purpose of testing its response code
func includePathInTest(path string) bool {
var hanging = path == "/v1/status/peers" || path == "/v1/agent/monitor" || path == "/v1/agent/reload" // these hang
var custom = path == "/v1/query" || path == "/v1/query/" // these have custom logic
return !(hanging || custom)
ignored := false
for _, p := range ignoredEndpoints {
if p == path {
ignored = true
break
}
}
for _, p := range customEndpoints {
if p == path {
ignored = true
break
}
}
return !ignored
}
func TestHTTPAPI_MethodNotAllowed_OSS(t *testing.T) {