From 90fe8b3418f9ee29e635921a60f5e3c453cdb76c Mon Sep 17 00:00:00 2001
From: Ethan Chu <xychu2008@gmail.com>
Date: Fri, 30 Sep 2016 14:26:12 +0800
Subject: [PATCH] Add `AddAccessibleService` to testutil

`AddAccessibleService` works just like `AddService` but also passing
"address" and "port". It is helpfu when you need to prepare a
fakeService that will be accessed later in target source code.
---
 testutil/README.md         |  3 +++
 testutil/server_methods.go | 15 +++++++++++++--
 testutil/server_wrapper.go |  4 ++++
 3 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/testutil/README.md b/testutil/README.md
index da5d682ca3..bd84f822d3 100644
--- a/testutil/README.md
+++ b/testutil/README.md
@@ -58,6 +58,9 @@ func TestFoo_bar(t *testing.T) {
 	// Create a service
 	srv1.AddService(t, "redis", structs.HealthPassing, []string{"master"})
 
+	// Create a service that will be accessed in target source code
+	srv1.AddAccessibleService("redis", structs.HealthPassing, "127.0.0.1", 6379, []string{"master"})
+
 	// Create a service check
 	srv1.AddCheck(t, "service:redis", "redis", structs.HealthPassing)
 
diff --git a/testutil/server_methods.go b/testutil/server_methods.go
index 90eeb0d4fd..8f4b067ad6 100644
--- a/testutil/server_methods.go
+++ b/testutil/server_methods.go
@@ -109,9 +109,20 @@ func (s *TestServer) ListKV(t *testing.T, prefix string) []string {
 // automatically adds a health check with the given status, which
 // can be one of "passing", "warning", or "critical".
 func (s *TestServer) AddService(t *testing.T, name, status string, tags []string) {
+	s.AddAddressableService(t, name, status, "", 0, tags) // set empty address and 0 as port for non-accessible service
+}
+
+// AddAddressableService adds a new service to the Consul instance by
+// passing "address" and "port". It is helpful when you need to prepare a fakeService
+// that maybe accessed with in target source code.
+// It also automatically adds a health check with the given status, which
+// can be one of "passing", "warning", or "critical", just like `AddService` does.
+func (s *TestServer) AddAddressableService(t *testing.T, name, status, address string, port int, tags []string) {
 	svc := &TestService{
-		Name: name,
-		Tags: tags,
+		Name:    name,
+		Tags:    tags,
+		Address: address,
+		Port:    port,
 	}
 	payload, err := s.encodePayload(svc)
 	if err != nil {
diff --git a/testutil/server_wrapper.go b/testutil/server_wrapper.go
index 286207700e..17615da8d1 100644
--- a/testutil/server_wrapper.go
+++ b/testutil/server_wrapper.go
@@ -56,6 +56,10 @@ func (w *WrappedServer) AddService(name, status string, tags []string) {
 	w.s.AddService(w.t, name, status, tags)
 }
 
+func (w *WrappedServer) AddAddressableService(name, status, address string, port int, tags []string) {
+	w.s.AddAddressableService(w.t, name, status, address, port, tags)
+}
+
 func (w *WrappedServer) AddCheck(name, serviceID, status string) {
 	w.s.AddCheck(w.t, name, serviceID, status)
 }