status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

ui: Fix freetext searching within the nodes page (#4819) 

Essentially this was missing a call to `super`. The error unfortuantely
didn't arise in the tests as it only errors when the node list has 4
items are more (the 4 columns), and the acceptence tests by change were
only filling the page with 3 nodes for test purposes.

I've bumped the amount of nodes up to 4 in the tests, which then causes
the tests to fail, made the fix by adding the `super` call, and the
tests now pass.

I also tested the UI/text searching on a 10,000 node system, and
everything now works as expected.
This commit is contained in:
John Cowen 2018-10-19 14:31:22 +01:00 committed by GitHub
parent a06b825a28
commit 297788408b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ui-v2/app/components/list-collection.js
View File

@ -17,6 +17,7 @@ export default Component.extend(WithResizing, {
this.columns = [25, 25, 25, 25]; this.columns = [25, 25, 25, 25];
}, },
didReceiveAttrs: function() { didReceiveAttrs: function() {
this._super(...arguments);
this._cellLayout = this['cell-layout'] = new PercentageColumns( this._cellLayout = this['cell-layout'] = new PercentageColumns(
get(this, 'items.length'), get(this, 'items.length'),
get(this, 'columns'), get(this, 'columns'),

14
ui-v2/tests/acceptance/components/catalog-filter.feature
View File

@ -2,7 +2,7 @@
Feature: components / catalog-filter Feature: components / catalog-filter
Scenario: Filtering [Model] Scenario: Filtering [Model]
Given 1 datacenter model with the value "dc-1" Given 1 datacenter model with the value "dc-1"
And 3 service models from yaml And 4 service models from yaml
--- ---
- ChecksPassing: 1 - ChecksPassing: 1
ChecksWarning: 0 ChecksWarning: 0
@ -13,8 +13,11 @@ Feature: components / catalog-filter
- ChecksPassing: 0 - ChecksPassing: 0
ChecksWarning: 0 ChecksWarning: 0
ChecksCritical: 1 ChecksCritical: 1
- ChecksPassing: 1
ChecksWarning: 0
ChecksCritical: 0
--- ---
And 3 node models from yaml And 4 node models from yaml
--- ---
- Checks: - Checks:
- Status: passing - Status: passing
@ -22,7 +25,8 @@ Feature: components / catalog-filter
- Status: warning - Status: warning
- Checks: - Checks:
- Status: critical - Status: critical
- Checks:
- Status: passing
--- ---
When I visit the [Page] page for yaml When I visit the [Page] page for yaml
--- ---
@ -30,12 +34,12 @@ Feature: components / catalog-filter
--- ---
Then the url should be [Url] Then the url should be [Url]
Then I see 3 [Model] models Then I see 4 [Model] models
And I see allIsSelected on the filter And I see allIsSelected on the filter
When I click passing on the filter When I click passing on the filter
And I see passingIsSelected on the filter And I see passingIsSelected on the filter
And I see 1 [Model] model And I see 2 [Model] models
When I click warning on the filter When I click warning on the filter
And I see warningIsSelected on the filter And I see warningIsSelected on the filter