From 16c7ce8b4cea789b437b6b6f418671b6ddfcd157 Mon Sep 17 00:00:00 2001 From: Matt Keeler Date: Wed, 30 Oct 2019 09:24:30 -0400 Subject: [PATCH] =?UTF-8?q?Add=20note=20about=20RPC=20multiplexing=20and?= =?UTF-8?q?=20TLS=20content=20type=20mutual=20exc=E2=80=A6=20(#6698)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- agent/pool/conn.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/agent/pool/conn.go b/agent/pool/conn.go index 8c81d25327..07e8f41721 100644 --- a/agent/pool/conn.go +++ b/agent/pool/conn.go @@ -17,4 +17,14 @@ const ( // that is supported and it might be the only one there // ever is. RPCTLSInsecure = 7 + + // NOTE: Currently we use values between 0 and 7 for the different + // "protocols" that we may ride over our "rpc" port. We had an idea of + // using TLS + ALPN for negotiating the protocol instead of our own + // bytes as it could provide other benefits. Currently our 0-7 values + // are mutually exclusive with any valid first byte of a TLS header + // The first TLS header byte will content a TLS content type and the + // values 0-19 are all explicitly unassigned and marked as + // requiring coordination. RFC 7983 does the marking and goes into + // some details about multiplexing connections and identifying TLS. )