From 146e1d387865ee790fce5bceeb8d3f2dca0250c3 Mon Sep 17 00:00:00 2001 From: Daniel Nephin Date: Wed, 28 Apr 2021 13:46:53 -0400 Subject: [PATCH] connect/proxy: remove t.Parallel from tests These tests run in under 10ms, t.Parallel provides no value and makes debuging failures more difficult. --- connect/proxy/config_test.go | 2 -- connect/proxy/conn_test.go | 9 ++------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/connect/proxy/config_test.go b/connect/proxy/config_test.go index ef99557652..ba2974d5da 100644 --- a/connect/proxy/config_test.go +++ b/connect/proxy/config_test.go @@ -14,8 +14,6 @@ import ( ) func TestUpstreamResolverFuncFromClient(t *testing.T) { - t.Parallel() - tests := []struct { name string cfg UpstreamConfig diff --git a/connect/proxy/conn_test.go b/connect/proxy/conn_test.go index 92e92f5cbc..2ca29fab5a 100644 --- a/connect/proxy/conn_test.go +++ b/connect/proxy/conn_test.go @@ -7,9 +7,10 @@ import ( "testing" "time" - "github.com/hashicorp/consul/sdk/testutil/retry" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" + + "github.com/hashicorp/consul/sdk/testutil/retry" ) // Assert io.Closer implementation @@ -65,8 +66,6 @@ func testConnPipelineSetup(t *testing.T) (net.Conn, net.Conn, *Conn, func()) { } func TestConn(t *testing.T) { - t.Parallel() - src, dst, c, stop := testConnPipelineSetup(t) defer stop() @@ -124,8 +123,6 @@ func TestConn(t *testing.T) { } func TestConnSrcClosing(t *testing.T) { - t.Parallel() - src, dst, c, stop := testConnPipelineSetup(t) defer stop() @@ -164,8 +161,6 @@ func TestConnSrcClosing(t *testing.T) { } func TestConnDstClosing(t *testing.T) { - t.Parallel() - src, dst, c, stop := testConnPipelineSetup(t) defer stop()