status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

agent: use const for default maintenance reason strings

This commit is contained in:
Ryan Uber 2015-01-21 14:45:09 -08:00
parent 52ff08b6c0
commit 124e7bfa7e
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
command/agent/agent.go
View File

@ -34,6 +34,12 @@ const (
// The ID of the faux health checks for maintenance mode
serviceMaintCheckPrefix = "_service_maintenance"
nodeMaintCheckID = "_node_maintenance"
// Default reasons for node/service maintenance mode
defaultNodeMaintReason = "Maintenance mode is enabled for this node, " +
"but no reason was provided. This is a default message."
defaultServiceMaintReason = "Maintenance mode is enabled for this " +
"service, but no reason was provided. This is a default message."
)
/*
@ -1041,7 +1047,7 @@ func (a *Agent) EnableServiceMaintenance(serviceID, reason string) error {
// Use default notes if no reason provided
if reason == "" {
reason = "Maintenance mode is enabled for this service"
reason = defaultServiceMaintReason
}
// Create and register the critical health check
@ -1089,7 +1095,7 @@ func (a *Agent) EnableNodeMaintenance(reason string) {
// Use a default notes value
if reason == "" {
reason = "Maintenance mode is enabled for this node"
reason = defaultNodeMaintReason
}
// Create and register the node maintenance check

4
command/agent/agent_test.go
View File

@ -952,7 +952,7 @@ func TestAgent_ServiceMaintenanceMode(t *testing.T) {
if !ok {
t.Fatalf("should have registered critical check")
}
if check.Notes == "" {
if check.Notes != defaultServiceMaintReason {
t.Fatalf("bad: %#v", check)
}
}
@ -993,7 +993,7 @@ func TestAgent_NodeMaintenanceMode(t *testing.T) {
if !ok {
t.Fatalf("should have registered critical node check")
}
if check.Notes == "" {
if check.Notes != defaultNodeMaintReason {
t.Fatalf("bad: %#v", check)
}
}