api: use WaitForResult() to improve health tests

api/health_test.go

@@ -1,8 +1,10 @@
 package api
 
 import (
+	"fmt"
 	"testing"
-	"time"
+
+	"github.com/hashicorp/consul/testutil"
 )
 
 func TestHealth_Node(t *testing.T) {
@@ -50,20 +52,21 @@ func TestHealth_Checks(t *testing.T) {
 	}
 	defer agent.ServiceDeregister("foo")
 
-	// Wait for the register...
+	testutil.WaitForResult(func() (bool, error) {
-	time.Sleep(20 * time.Millisecond)
+		checks, meta, err := health.Checks("foo", nil)
-
+		if err != nil {
-	checks, meta, err := health.Checks("foo", nil)
+			return false, err
-	if err != nil {
+		}
-		t.Fatalf("err: %v", err)
+		if meta.LastIndex == 0 {
-	}
+			return false, fmt.Errorf("bad: %v", meta)
-
+		}
-	if meta.LastIndex == 0 {
+		if len(checks) == 0 {
-		t.Fatalf("bad: %v", meta)
+			return false, fmt.Errorf("Bad: %v", checks)
-	}
+		}
-	if len(checks) == 0 {
+		return true, nil
-		t.Fatalf("Bad: %v", checks)
+	}, func(err error) {
-	}
+		t.Fatalf("err: %s", err)
+	})
 }
 
 func TestHealth_Service(t *testing.T) {