status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-02 00:46:43 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #13787 from hashicorp/fix-acl-read-token-self-expanded-panic

Browse Source 
Fix panic on acl token read with -self and -expanded
This commit is contained in:
Jared Kirschner 2022-07-18 20:34:50 -04:00 committed by GitHub
commit 067272b53f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/13787.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
cli: when `acl token read` is used with the `-self` and `-expanded` flags, return an error instead of panicking
```

7
command/acl/token/read/token_read.go
View File

@ -92,6 +92,13 @@ func (c *cmd) Run(args []string) int {
return 1 return 1
} }
} else { } else {
// TODO: consider updating this CLI command and underlying HTTP API endpoint
// to support expanded read of a "self" token, which is a much better user workflow.
if c.expanded {
c.UI.Error("Cannot use both -expanded and -self. Instead, use -expanded and -id=<accessor id>.")
return 1
}
t, _, err = client.ACL().TokenReadSelf(nil) t, _, err = client.ACL().TokenReadSelf(nil)
if err != nil { if err != nil {
c.UI.Error(fmt.Sprintf("Error reading token: %v", err)) c.UI.Error(fmt.Sprintf("Error reading token: %v", err))