2017-10-17 06:52:50 +00:00
|
|
|
package rtt
|
2015-10-16 07:03:16 +00:00
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
2018-08-27 15:37:13 +00:00
|
|
|
"github.com/hashicorp/consul/testrpc"
|
|
|
|
|
pkg refactor
command/agent/* -> agent/*
command/consul/* -> agent/consul/*
command/agent/command{,_test}.go -> command/agent{,_test}.go
command/base/command.go -> command/base.go
command/base/* -> command/*
commands.go -> command/commands.go
The script which did the refactor is:
(
cd $GOPATH/src/github.com/hashicorp/consul
git mv command/agent/command.go command/agent.go
git mv command/agent/command_test.go command/agent_test.go
git mv command/agent/flag_slice_value{,_test}.go command/
git mv command/agent .
git mv command/base/command.go command/base.go
git mv command/base/config_util{,_test}.go command/
git mv commands.go command/
git mv consul agent
rmdir command/base/
gsed -i -e 's|package agent|package command|' command/agent{,_test}.go
gsed -i -e 's|package agent|package command|' command/flag_slice_value{,_test}.go
gsed -i -e 's|package base|package command|' command/base.go command/config_util{,_test}.go
gsed -i -e 's|package main|package command|' command/commands.go
gsed -i -e 's|base.Command|BaseCommand|' command/commands.go
gsed -i -e 's|agent.Command|AgentCommand|' command/commands.go
gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/commands.go
gsed -i -e 's|base\.||' command/commands.go
gsed -i -e 's|command\.||' command/commands.go
gsed -i -e 's|command|c|' main.go
gsed -i -e 's|range Commands|range command.Commands|' main.go
gsed -i -e 's|Commands: Commands|Commands: command.Commands|' main.go
gsed -i -e 's|base\.BoolValue|BoolValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.DurationValue|DurationValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.StringValue|StringValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.UintValue|UintValue|' command/operator_autopilot_set.go
gsed -i -e 's|\bCommand\b|BaseCommand|' command/base.go
gsed -i -e 's|BaseCommand Options|Command Options|' command/base.go
gsed -i -e 's|base.Command|BaseCommand|' command/*.go
gsed -i -e 's|c\.Command|c.BaseCommand|g' command/*.go
gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/*_test.go
gsed -i -e 's|base\.||' command/*_test.go
gsed -i -e 's|\bCommand\b|AgentCommand|' command/agent{,_test}.go
gsed -i -e 's|cmd.AgentCommand|cmd.BaseCommand|' command/agent.go
gsed -i -e 's|cli.AgentCommand = new(Command)|cli.Command = new(AgentCommand)|' command/agent_test.go
gsed -i -e 's|exec.AgentCommand|exec.Command|' command/agent_test.go
gsed -i -e 's|exec.BaseCommand|exec.Command|' command/agent_test.go
gsed -i -e 's|NewTestAgent|agent.NewTestAgent|' command/agent_test.go
gsed -i -e 's|= TestConfig|= agent.TestConfig|' command/agent_test.go
gsed -i -e 's|: RetryJoin|: agent.RetryJoin|' command/agent_test.go
gsed -i -e 's|\.\./\.\./|../|' command/config_util_test.go
gsed -i -e 's|\bverifyUniqueListeners|VerifyUniqueListeners|' agent/config{,_test}.go command/agent.go
gsed -i -e 's|\bserfLANKeyring\b|SerfLANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go
gsed -i -e 's|\bserfWANKeyring\b|SerfWANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go
gsed -i -e 's|\bNewAgent\b|agent.New|g' command/agent{,_test}.go
gsed -i -e 's|\bNewAgent|New|' agent/{acl_test,agent,testagent}.go
gsed -i -e 's|\bAgent\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bBool\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bDefaultConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bDevConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bMergeConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bReadConfigPaths\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bParseMetaPair\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bSerfLANKeyring\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bSerfWANKeyring\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|circonus\.agent|circonus|g' command/agent{,_test}.go
gsed -i -e 's|logger\.agent|logger|g' command/agent{,_test}.go
gsed -i -e 's|metrics\.agent|metrics|g' command/agent{,_test}.go
gsed -i -e 's|// agent.Agent|// agent|' command/agent{,_test}.go
gsed -i -e 's|a\.agent\.Config|a.Config|' command/agent{,_test}.go
gsed -i -e 's|agent\.AppendSliceValue|AppendSliceValue|' command/{configtest,validate}.go
gsed -i -e 's|consul/consul|agent/consul|' GNUmakefile
gsed -i -e 's|\.\./test|../../test|' agent/consul/server_test.go
# fix imports
f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * | grep '\.go')
gsed -i -e 's|github.com/hashicorp/consul/command/agent|github.com/hashicorp/consul/agent|' $f
goimports -w $f
f=$(grep -rl 'github.com/hashicorp/consul/consul' * | grep '\.go')
gsed -i -e 's|github.com/hashicorp/consul/consul|github.com/hashicorp/consul/agent/consul|' $f
goimports -w $f
goimports -w command/*.go main.go
)
2017-06-09 22:28:28 +00:00
|
|
|
"github.com/hashicorp/consul/agent"
|
2017-07-06 10:34:00 +00:00
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
2017-04-29 16:34:02 +00:00
|
|
|
"github.com/hashicorp/consul/testutil/retry"
|
2015-10-16 07:03:16 +00:00
|
|
|
"github.com/hashicorp/serf/coordinate"
|
|
|
|
"github.com/mitchellh/cli"
|
|
|
|
)
|
|
|
|
|
2017-10-17 06:52:50 +00:00
|
|
|
func TestRTTCommand_noTabs(t *testing.T) {
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2017-10-17 06:52:50 +00:00
|
|
|
if strings.ContainsRune(New(cli.NewMockUi()).Help(), '\t') {
|
2017-10-17 13:44:20 +00:00
|
|
|
t.Fatal("help has tabs")
|
2017-10-17 06:52:50 +00:00
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestRTTCommand_BadArgs(t *testing.T) {
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2017-10-11 12:51:18 +00:00
|
|
|
tests := []struct {
|
|
|
|
args []string
|
|
|
|
}{
|
|
|
|
{args: []string{}},
|
|
|
|
{args: []string{"node1", "node2", "node3"}},
|
|
|
|
{args: []string{"-wan", "node1", "node2"}},
|
|
|
|
{args: []string{"-wan", "node1.dc1", "node2"}},
|
|
|
|
{args: []string{"-wan", "node1", "node2.dc1"}},
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
|
|
|
|
2017-10-11 12:51:18 +00:00
|
|
|
for _, tt := range tests {
|
|
|
|
t.Run(strings.Join(tt.args, " "), func(t *testing.T) {
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2017-10-11 12:51:18 +00:00
|
|
|
if code := c.Run(tt.args); code != 1 {
|
|
|
|
t.Fatalf("expected return code 1, got %d", code)
|
|
|
|
}
|
|
|
|
})
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestRTTCommand_LAN(t *testing.T) {
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2019-02-14 15:59:14 +00:00
|
|
|
a := agent.NewTestAgent(t, t.Name(), `
|
2017-09-25 18:40:42 +00:00
|
|
|
consul = {
|
|
|
|
coordinate = {
|
|
|
|
update_period = "10ms"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
`)
|
2015-10-16 07:03:16 +00:00
|
|
|
defer a.Shutdown()
|
2018-08-27 15:37:13 +00:00
|
|
|
testrpc.WaitForLeader(t, a.RPC, "dc1")
|
2015-10-16 07:03:16 +00:00
|
|
|
|
|
|
|
// Inject some known coordinates.
|
|
|
|
c1 := coordinate.NewCoordinate(coordinate.DefaultConfig())
|
|
|
|
c2 := c1.Clone()
|
|
|
|
c2.Vec[0] = 0.123
|
2018-01-28 18:40:13 +00:00
|
|
|
distStr := fmt.Sprintf("%.3f ms", c1.DistanceTo(c2).Seconds()*1000.0)
|
2015-10-23 22:19:14 +00:00
|
|
|
{
|
|
|
|
req := structs.CoordinateUpdateRequest{
|
2017-05-22 11:59:36 +00:00
|
|
|
Datacenter: a.Config.Datacenter,
|
|
|
|
Node: a.Config.NodeName,
|
2015-10-23 22:19:14 +00:00
|
|
|
Coord: c1,
|
|
|
|
}
|
|
|
|
var reply struct{}
|
2017-05-22 11:59:36 +00:00
|
|
|
if err := a.RPC("Coordinate.Update", &req, &reply); err != nil {
|
2015-10-23 22:19:14 +00:00
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
2015-10-23 22:19:14 +00:00
|
|
|
{
|
|
|
|
req := structs.RegisterRequest{
|
2017-05-22 11:59:36 +00:00
|
|
|
Datacenter: a.Config.Datacenter,
|
2015-10-23 22:19:14 +00:00
|
|
|
Node: "dogs",
|
|
|
|
Address: "127.0.0.2",
|
|
|
|
}
|
|
|
|
var reply struct{}
|
2017-05-22 11:59:36 +00:00
|
|
|
if err := a.RPC("Catalog.Register", &req, &reply); err != nil {
|
2015-10-23 22:19:14 +00:00
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
2015-10-23 22:19:14 +00:00
|
|
|
{
|
|
|
|
var reply struct{}
|
|
|
|
req := structs.CoordinateUpdateRequest{
|
2017-05-22 11:59:36 +00:00
|
|
|
Datacenter: a.Config.Datacenter,
|
2015-10-23 22:19:14 +00:00
|
|
|
Node: "dogs",
|
|
|
|
Coord: c2,
|
|
|
|
}
|
2017-05-22 11:59:36 +00:00
|
|
|
if err := a.RPC("Coordinate.Update", &req, &reply); err != nil {
|
2015-10-23 22:19:14 +00:00
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
|
|
|
|
2016-10-25 20:46:54 +00:00
|
|
|
// Ask for the RTT of two known nodes
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2016-10-25 20:46:54 +00:00
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
|
|
|
a.Config.NodeName,
|
2016-10-25 20:46:54 +00:00
|
|
|
"dogs",
|
|
|
|
}
|
|
|
|
// Wait for the updates to get flushed to the data store.
|
2017-05-04 22:52:53 +00:00
|
|
|
retry.Run(t, func(r *retry.R) {
|
2015-10-16 07:03:16 +00:00
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
2017-04-29 16:34:02 +00:00
|
|
|
r.Fatalf("bad: %d: %#v", code, ui.ErrorWriter.String())
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure the proper RTT was reported in the output.
|
2018-01-28 18:40:13 +00:00
|
|
|
expected := fmt.Sprintf("rtt: %s", distStr)
|
2015-10-16 07:56:15 +00:00
|
|
|
if !strings.Contains(ui.OutputWriter.String(), expected) {
|
2017-04-29 16:34:02 +00:00
|
|
|
r.Fatalf("bad: %#v", ui.OutputWriter.String())
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
2017-04-29 16:34:02 +00:00
|
|
|
})
|
2015-10-16 07:56:15 +00:00
|
|
|
|
2015-10-16 19:45:25 +00:00
|
|
|
// Default to the agent's node.
|
2015-10-16 07:56:15 +00:00
|
|
|
{
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2015-10-16 07:56:15 +00:00
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-10-16 07:56:15 +00:00
|
|
|
"dogs",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d: %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure the proper RTT was reported in the output.
|
2018-01-28 18:40:13 +00:00
|
|
|
expected := fmt.Sprintf("rtt: %s", distStr)
|
2015-10-16 19:45:25 +00:00
|
|
|
if !strings.Contains(ui.OutputWriter.String(), expected) {
|
2015-10-16 07:56:15 +00:00
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
|
|
|
|
// Try an unknown node.
|
2015-10-16 07:56:15 +00:00
|
|
|
{
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2015-10-16 07:03:16 +00:00
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
|
|
|
a.Config.NodeName,
|
2015-10-16 07:03:16 +00:00
|
|
|
"nope",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("bad: %d: %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
2015-10-16 07:56:15 +00:00
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestRTTCommand_WAN(t *testing.T) {
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2019-02-14 15:59:14 +00:00
|
|
|
a := agent.NewTestAgent(t, t.Name(), ``)
|
2015-10-16 07:03:16 +00:00
|
|
|
defer a.Shutdown()
|
2018-08-27 15:37:13 +00:00
|
|
|
testrpc.WaitForLeader(t, a.RPC, "dc1")
|
2015-10-16 07:03:16 +00:00
|
|
|
|
2017-05-22 11:59:36 +00:00
|
|
|
node := fmt.Sprintf("%s.%s", a.Config.NodeName, a.Config.Datacenter)
|
2015-10-16 07:03:16 +00:00
|
|
|
|
|
|
|
// We can't easily inject WAN coordinates, so we will just query the
|
|
|
|
// node with itself.
|
2015-10-16 07:56:15 +00:00
|
|
|
{
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2015-10-16 07:03:16 +00:00
|
|
|
args := []string{
|
|
|
|
"-wan",
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-10-16 07:03:16 +00:00
|
|
|
node,
|
|
|
|
node,
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d: %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure there was some kind of RTT reported in the output.
|
2015-10-16 19:45:25 +00:00
|
|
|
if !strings.Contains(ui.OutputWriter.String(), "rtt: ") {
|
2015-10-16 07:03:16 +00:00
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
2015-10-16 07:56:15 +00:00
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
|
2015-10-16 19:45:25 +00:00
|
|
|
// Default to the agent's node.
|
2015-10-16 07:56:15 +00:00
|
|
|
{
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2015-10-16 07:03:16 +00:00
|
|
|
args := []string{
|
2015-10-16 07:56:15 +00:00
|
|
|
"-wan",
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-10-16 07:56:15 +00:00
|
|
|
node,
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d: %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure there was some kind of RTT reported in the output.
|
2015-10-16 19:45:25 +00:00
|
|
|
if !strings.Contains(ui.OutputWriter.String(), "rtt: ") {
|
2015-10-16 07:56:15 +00:00
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Try an unknown node.
|
|
|
|
{
|
2017-10-17 06:52:50 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
2015-10-16 07:56:15 +00:00
|
|
|
args := []string{
|
2015-10-16 07:03:16 +00:00
|
|
|
"-wan",
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-10-16 07:03:16 +00:00
|
|
|
node,
|
|
|
|
"dc1.nope",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("bad: %d: %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
2015-10-16 07:56:15 +00:00
|
|
|
}
|
2015-10-16 07:03:16 +00:00
|
|
|
}
|