consul/.golangci.yml

linters:
  disable-all: true
  enable:
    - gofmt
    - govet
    - unconvert
    - staticcheck

issues:
  # Disable the default exclude list so that all excludes are explicitly
  # defined in this file.
  exclude-use-default: false

  exclude-rules:
    # Temp Ignore SA9004: only the first constant in this group has an explicit type
    # https://staticcheck.io/docs/checks#SA9004
    - linters: [staticcheck]
      text: "SA9004:"

    # Temp ignore SA4006: this value of `x` is never used
    - linters: [staticcheck]
      text: "SA4006:"

    # Temp ignore SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test
    - linters: [staticcheck]
      text: "SA2002:"

linters-settings:
  gofmt:
    simplify: false

run:
  timeout: 5m
ci: Use golangci-lint for linting Using golangci-lint has a number of advantages: - adding new linters becomes much easier, its a couple lines of yaml config instead of more bash scripting - it enables whitelisting of issues using inline comments or regex - when running multiple linters less work is done. The parsed source can be reused by multiple linters - linters are run in parallel to reduce CI runtime. 2020-03-11 21:18:03 -04:00			`linters:`
			`disable-all: true`
			`enable:`
			`- gofmt`
			`- govet`
Add unconvert linter To find unnecessary type convertions 2020-04-16 13:35:28 -04:00			`- unconvert`
ci: Add staticcheck and fix most errors Three of the checks are temporarily disabled to limit the size of the diff, and allow us to enable all the other checks in CI. In a follow up we can fix the issues reported by the other checks one at a time, and enable them. 2020-05-14 17:02:52 -04:00			`- staticcheck`
ci: Use golangci-lint for linting Using golangci-lint has a number of advantages: - adding new linters becomes much easier, its a couple lines of yaml config instead of more bash scripting - it enables whitelisting of issues using inline comments or regex - when running multiple linters less work is done. The parsed source can be reused by multiple linters - linters are run in parallel to reduce CI runtime. 2020-03-11 21:18:03 -04:00
			`issues:`
			`# Disable the default exclude list so that all excludes are explicitly`
			`# defined in this file.`
			`exclude-use-default: false`

ci: Add staticcheck and fix most errors Three of the checks are temporarily disabled to limit the size of the diff, and allow us to enable all the other checks in CI. In a follow up we can fix the issues reported by the other checks one at a time, and enable them. 2020-05-14 17:02:52 -04:00			`exclude-rules:`
			`# Temp Ignore SA9004: only the first constant in this group has an explicit type`
			`# https://staticcheck.io/docs/checks#SA9004`
			`- linters: [staticcheck]`
			`text: "SA9004:"`

			# Temp ignore SA4006: this value of `x` is never used
			`- linters: [staticcheck]`
			`text: "SA4006:"`

			`# Temp ignore SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test`
			`- linters: [staticcheck]`
			`text: "SA2002:"`

ci: Use golangci-lint for linting Using golangci-lint has a number of advantages: - adding new linters becomes much easier, its a couple lines of yaml config instead of more bash scripting - it enables whitelisting of issues using inline comments or regex - when running multiple linters less work is done. The parsed source can be reused by multiple linters - linters are run in parallel to reduce CI runtime. 2020-03-11 21:18:03 -04:00			`linters-settings:`
			`gofmt:`
			`simplify: false`
Add lint to makefile And support for setting build tags in CI lint job. Removed the unused 'test-ci' target. 2020-03-24 16:14:12 -04:00
			`run:`
			`timeout: 5m`