mirror of
https://github.com/status-im/community-dapp.git
synced 2025-02-21 10:38:09 +00:00
974ec940d1
The `FeaturedVotingContract` comes with a check in `initializeVoting()` that aims to ensure that the community that the voting is being initialized for, has not been featured previously for #n votings. This is denoted as the `cooldownPeriod`. If `cooldownPeriod = 1`, this means there needs to be at least one voting which doesn't include the community in question, that came *after* the voting that did. The internal `_isInCooldownPeriod()` check has a bug which will return false positives for any communiy that has been featured before, regardless of `cooldownPeriod`s value. When iterating previous votings, the contract actually needs to start with the last one and iterate downwards, however it does the opposite so it will never reach the correct votings to check. This commit fixes the check and adds two tests to cover the case accordingly.
status-community-dapp
Community directory curator dApp for Status
API
Proposed api is available here
Running the project
Note: Use node v18.15.0
- Install dependencies: Run
yarnto install the necessary packages and dependencies. - Run local hardhat node: Navigate to the
packages/contractdirectory and runyarn dev. - Deploy contracts: Navigate to the
packages/contractsdirectory and runyarn dev:deployto deploy the contracts needed for the project. - Start the app: Run
VOTING_CONTRACT=hex_addr DIRECTORY_CONTRACT=hex_addr MULTICALL_CONTRACT=hex_addr TOKEN_CONTRACT=hex_addr yarn devto start the application. Make sure to replacehex_addrwith the actual addresses of the contracts you deployed in step 3.
Once the app is run, connect to the wallet. NOTE: in 'production' mode it has to be Status wallet.