mirror of https://github.com/status-im/codimd.git
Merge pull request #684 from hackmdio/fixDropboxAppKey
Fix not passing app key correctly in dropbox config ⚠️ Dropbox ClientSecret was leaked ⚠️ Fixes #683
This commit is contained in:
commit
feb89f02e2
2
app.js
2
app.js
|
@ -34,7 +34,7 @@ var data = {
|
|||
version: config.version,
|
||||
GOOGLE_API_KEY: config.google.clientSecret,
|
||||
GOOGLE_CLIENT_ID: config.google.clientID,
|
||||
DROPBOX_APP_KEY: config.dropbox.clientSecret
|
||||
DROPBOX_APP_KEY: config.dropbox.appKey
|
||||
}
|
||||
|
||||
ejs.renderFile(constpath, data, {}, function (err, str) {
|
||||
|
|
|
@ -81,7 +81,8 @@ module.exports = {
|
|||
},
|
||||
dropbox: {
|
||||
clientID: undefined,
|
||||
clientSecret: undefined
|
||||
clientSecret: undefined,
|
||||
appKey: undefined
|
||||
},
|
||||
google: {
|
||||
clientID: undefined,
|
||||
|
|
|
@ -44,7 +44,8 @@ if (fs.existsSync(basePath)) {
|
|||
},
|
||||
dropbox: {
|
||||
clientID: getSecret('dropbox_clientID'),
|
||||
clientSecret: getSecret('dropbox_clientSecret')
|
||||
clientSecret: getSecret('dropbox_clientSecret'),
|
||||
appKey: getSecret('dropbox_appKey')
|
||||
},
|
||||
google: {
|
||||
clientID: getSecret('google_clientID'),
|
||||
|
|
|
@ -56,7 +56,8 @@ module.exports = {
|
|||
},
|
||||
dropbox: {
|
||||
clientID: process.env.HMD_DROPBOX_CLIENTID,
|
||||
clientSecret: process.env.HMD_DROPBOX_CLIENTSECRET
|
||||
clientSecret: process.env.HMD_DROPBOX_CLIENTSECRET,
|
||||
appKey: process.env.HMD_DROPBOX_APPKEY
|
||||
},
|
||||
google: {
|
||||
clientID: process.env.HMD_GOOGLE_CLIENTID,
|
||||
|
|
Loading…
Reference in New Issue