Merge pull request #1421 from hackmdio/fix/cannot-download-pdf

Fix server crash when download pdf twice
2020-02-27 00:31:51 +08:00 · 2020-02-27 00:31:51 +08:00 · e33bafd35d
parent 90898e700f b8fb9dbb9e
commit e33bafd35d
1 changed files with 4 additions and 1 deletions
--- a/lib/note/noteActions.js
+++ b/lib/note/noteActions.js
@ -95,8 +95,11 @@ function actionPDF (req, res, note) {
    res.setHeader('Cache-Control', 'private')
    res.setHeader('Content-Type', 'application/pdf; charset=UTF-8')
    res.setHeader('X-Robots-Tag', 'noindex, nofollow') // prevent crawling
+    stream.on('end', () => {
+      stream.close()
+      fs.unlinkSync(pdfPath)
+    })
    stream.pipe(res)
-    fs.unlinkSync(pdfPath)
  })
 }