Fix author creation in operationCallback might cause unique constraint validation error

2017-01-12 17:18:24 +08:00 · 2017-01-12 17:18:24 +08:00 · 7e191acbde
parent ffa14cfeef
commit 7e191acbde
1 changed files with 19 additions and 11 deletions
--- a/lib/realtime.js
+++ b/lib/realtime.js
@ -652,17 +652,25 @@ function operationCallback(socket, operation) {
        if (!user) return;
        userId = socket.request.user.id;
        if (!note.authors[userId]) {
-            models.Author.create({
+            models.Author.findOrCreate({
+                where: {
+                    noteId: noteId,
+                    userId: userId
+                },
+                defaults: {
                    noteId: noteId,
                    userId: userId,
                    color: user.color
-            }).then(function (author) {
+                }
+            }).spread(function (author, created) {
+                if (author) {
                    note.authors[author.userId] = {
                        userid: author.userId,
                        color: author.color,
                        photo: user.photo,
                        name: user.name
                    };
+                }
            }).catch(function (err) {
                return logger.error('operation callback failed: ' + err);
            });