status-im/codex-contracts-eth
2
0
Fork 0
mirror of https://github.com/status-im/codex-contracts-eth.git synced 2025-02-12 08:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

vault: fix transfer to self

Browse Source
This commit is contained in:
Mark Spanbroek 2025-02-05 14:04:46 +01:00
parent 523544a4e8
commit f6fb441dec
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contracts/vault/VaultBase.sol
View File

@ -126,15 +126,13 @@ abstract contract VaultBase {
require(lock.isLocked(), LockRequired()); require(lock.isLocked(), LockRequired());
Account memory sender = _getAccount(controller, fund, from); Account memory sender = _getAccount(controller, fund, from);
Account memory receiver = _getAccount(controller, fund, to);
require(amount <= sender.balance.available, InsufficientBalance()); require(amount <= sender.balance.available, InsufficientBalance());
sender.balance.available -= amount; sender.balance.available -= amount;
receiver.balance.available += amount;
_checkAccountInvariant(sender, lock); _checkAccountInvariant(sender, lock);
_accounts[controller][fund][from] = sender; _accounts[controller][fund][from] = sender;
Account memory receiver = _getAccount(controller, fund, to);
receiver.balance.available += amount;
_accounts[controller][fund][to] = receiver; _accounts[controller][fund][to] = receiver;
} }

6
test/Vault.tests.js
View File

@ -292,6 +292,12 @@ describe("Vault", function () {
expect(await vault.getBalance(fund, address3)).to.equal(amount) expect(await vault.getBalance(fund, address3)).to.equal(amount)
}) })
it("can transfer to self", async function () {
await setAutomine(true)
await vault.transfer(fund, address1, address1, amount)
expect(await vault.getBalance(fund, address1)).to.equal(amount);
})
it("does not transfer more than the balance", async function () { it("does not transfer more than the balance", async function () {
await setAutomine(true) await setAutomine(true)
await expect( await expect(