status-im/cabot
2
0
Fork 0
mirror of https://github.com/status-im/cabot.git synced 2025-02-22 09:28:06 +00:00
Code Issues Projects Releases Wiki Activity

Better error message when Jenkins job has no build (#567)

Browse Source 
If a job has no build yet, then the check result was
`'NoneType' object has no attribute '__getitem__'`,
making it hard to understand what is going on.

Now we catch that issue early-on and raise an Exception.

All in all this is not great code - we should decide once and for all
if get_job_status is supposed to bubble up issues as return_codes
or if we can use Exceptions.
This commit is contained in:
Jean-Frédéric 2017-09-21 18:06:42 +01:00 committed by GitHub
parent b9ceea48a4
commit 12d054efeb
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cabot/cabotapp/jenkins.py
View File

@ -25,7 +25,10 @@ def get_job_status(jenkins_config, jobname):
client = _get_jenkins_client(jenkins_config)
try:
job = client.get_job_info(jobname)
last_build = client.get_build_info(jobname, job['lastCompletedBuild']['number'])
last_completed_build = job['lastCompletedBuild']
if not last_completed_build:
raise Exception("job has no build")
last_build = client.get_build_info(jobname, last_completed_build['number'])
ret['status_code'] = 200
ret['job_number'] = last_build['number']