Do not allow blob fields to overflow

This commit is contained in:
dancoffman 2022-12-12 14:48:05 -08:00
parent 0f54189400
commit e5338b771f
No known key found for this signature in database
GPG Key ID: 47B1F53E36A9B3CC
1 changed files with 14 additions and 3 deletions

View File

@ -20,7 +20,19 @@ const SETUP_FILE_PATH = existsSync(setupFileName)
const BLOB_BYTE_COUNT = FIELD_ELEMENTS_PER_BLOB * BYTES_PER_FIELD_ELEMENT; const BLOB_BYTE_COUNT = FIELD_ELEMENTS_PER_BLOB * BYTES_PER_FIELD_ELEMENT;
const generateRandomBlob = () => new Uint8Array(randomBytes(BLOB_BYTE_COUNT)); const MAX_TOP_BYTE = 114;
const generateRandomBlob = () => {
return new Uint8Array(
randomBytes(BLOB_BYTE_COUNT).map((x, i) => {
// Set the top byte to be low enough that the field element doesn't overflow the BLS modulus
if (x > MAX_TOP_BYTE && i % BYTES_PER_FIELD_ELEMENT == 31) {
return Math.floor(Math.random() * MAX_TOP_BYTE);
}
return x;
}),
);
};
describe("C-KZG", () => { describe("C-KZG", () => {
beforeAll(async () => { beforeAll(async () => {
@ -50,8 +62,7 @@ describe("C-KZG", () => {
); );
}); });
// Just don't call verifyAggregateKzgProof when there are no blobs or commitments it("verifies the aggregate proof of empty blobs and commitments", () => {
it.skip("verifies the aggregate proof of empty blobs and commitments", () => {
expect(verifyAggregateKzgProof([], [], computeAggregateKzgProof([]))).toBe( expect(verifyAggregateKzgProof([], [], computeAggregateKzgProof([]))).toBe(
true, true,
); );