From a7557be070a5133361d3516567e1bdaeab6092e3 Mon Sep 17 00:00:00 2001 From: Stefan Bratanov Date: Thu, 24 Nov 2022 12:32:03 +0000 Subject: [PATCH] readme improvements --- bindings/java/.gitignore | 4 +--- bindings/java/README.md | 6 +++--- bindings/java/lib/.gitignore | 3 +++ src/Makefile | 3 ++- 4 files changed, 9 insertions(+), 7 deletions(-) create mode 100644 bindings/java/lib/.gitignore diff --git a/bindings/java/.gitignore b/bindings/java/.gitignore index 63057cf..3c83e94 100644 --- a/bindings/java/.gitignore +++ b/bindings/java/.gitignore @@ -1,4 +1,2 @@ -lib/ *.class -*.o -*.a \ No newline at end of file +*.o \ No newline at end of file diff --git a/bindings/java/README.md b/bindings/java/README.md index 5d28838..6c476a6 100644 --- a/bindings/java/README.md +++ b/bindings/java/README.md @@ -2,8 +2,8 @@ ## Prerequisites -* Follow the instructions in the home README.md to create the libblst.a. -* JAVA_HOME environment variable is set to a jdk with an `include` folder containing jni.h file. +* Follow the instructions in the [README.md](../../README.md) to install blst and C-KZG. +* JAVA_HOME environment variable is set to a JDK with an `include` folder containing a jni.h file. ## Windows @@ -14,7 +14,7 @@ TBC ## Linux ```bash -clang -O -Wall -shared -fPIC -I../../blst/bindings -I../../src/ -I${JAVA_HOME}/include -I${JAVA_HOME}/include/linux -o lib/libckzg4844jni.so c_kzg_4844_jni.c ../../src/c_kzg_4844.c ../../blst/libblst.a +clang -O -Wall -shared -fPIC -I../../blst/bindings -I../../src/ -I${JAVA_HOME}/include -I${JAVA_HOME}/include/linux -o lib/libckzg4844jni.so c_kzg_4844_jni.c c_kzg_4844.o ../../lib/libblst.a ``` ## Mac-OS diff --git a/bindings/java/lib/.gitignore b/bindings/java/lib/.gitignore new file mode 100644 index 0000000..0bda782 --- /dev/null +++ b/bindings/java/lib/.gitignore @@ -0,0 +1,3 @@ +*.dll +*.so +*.dylib \ No newline at end of file diff --git a/src/Makefile b/src/Makefile index 5ea4cc7..e46d320 100644 --- a/src/Makefile +++ b/src/Makefile @@ -15,6 +15,7 @@ blst: cp libblst.a ../lib && \ cp bindings/*.h ../inc -# Copy make sure c_kzg_4844.o is built and copy it for the NodeJS bindings +# Make sure c_kzg_4844.o is built and copy it for the NodeJS and Java bindings lib: c_kzg_4844.o Makefile cp *.o ../bindings/node.js + cp *.o ../bindings/java