status-im
/
c-kzg-4844
mirror of https://github.com/status-im/c-kzg-4844.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use non-contiguous array for vector_lincomb

This commit is contained in:
Ramana Kumar 2022-10-01 15:55:38 +01:00
parent e33064cf28
commit 7dcd70b95e
No known key found for this signature in database
GPG Key ID: ED471C788B900433
4 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/c_kzg.h
View File

@ -108,7 +108,7 @@ void free_poly_l(poly_l *p);
// kzg_proofs.c
//
void fr_vector_lincomb(fr_t out[], const fr_t *vectors, const fr_t *scalars, uint64_t n, uint64_t m);
void fr_vector_lincomb(fr_t out[], const fr_t *vectors[], const fr_t *scalars, uint64_t n, uint64_t m);
/**
* Stores the setup and parameters needed for computing KZG proofs.

2
src/c_kzg_4844.c
View File

@ -69,7 +69,7 @@ void free_trusted_setup(KZGSettings *s) {
void compute_powers(BLSFieldElement out[], const BLSFieldElement *x, uint64_t n) { fr_pow(out, x, n); }
void vector_lincomb(BLSFieldElement out[], const BLSFieldElement *vectors, const BLSFieldElement *scalars, uint64_t num_vectors, uint64_t vector_len) {
void vector_lincomb(BLSFieldElement out[], const BLSFieldElement[] *vectors, const BLSFieldElement *scalars, uint64_t num_vectors, uint64_t vector_len) {
fr_vector_lincomb(out, vectors, scalars, num_vectors, vector_len);
}

2
src/c_kzg_4844.h
View File

@ -38,7 +38,7 @@ void free_trusted_setup(KZGSettings *s);
void compute_powers(BLSFieldElement out[], const BLSFieldElement *x, uint64_t n);
void vector_lincomb(BLSFieldElement out[], const BLSFieldElement *vectors, const BLSFieldElement *scalars, uint64_t num_vectors, uint64_t vector_len);
void vector_lincomb(BLSFieldElement out[], const BLSFieldElement *vectors[], const BLSFieldElement *scalars, uint64_t num_vectors, uint64_t vector_len);
void g1_lincomb(KZGCommitment *out, const KZGCommitment points[], const BLSFieldElement scalars[], uint64_t num_points);

15
src/kzg_proofs.c
View File

@ -31,15 +31,14 @@
/**
* Compute linear combinations of a sequence of vectors with some scalars
*/
void fr_vector_lincomb(fr_t out[], const fr_t *vectors, const fr_t *scalars, uint64_t n, uint64_t m) {
fr_t (*vectors_ptr)[n][m] = (fr_t (*)[n][m]) vectors;
void fr_vector_lincomb(fr_t out[], const fr_t *vectors[], const fr_t *scalars, uint64_t n, uint64_t m) {
fr_t tmp;
uint64_t i, j;
for (j = 0; j < m; j++)
out[j] = fr_zero;
for (i = 0; i < n; i++) {
for (j = 0; j < m; j++) {
fr_mul(&tmp, &scalars[i], &((*vectors_ptr)[i][j]));
fr_mul(&tmp, &scalars[i], &vectors[i][j]);
fr_add(&out[j], &out[j], &tmp);
}
}
@ -744,22 +743,24 @@ void fr_vector_lincomb_simple_test(void) {
fr_add(&fr2, &fr_one, &fr_one);
fr_add(&fr3, &fr2, &fr_one);
fr_t out[m];
const fr_t vectors[2][3] = { { fr_one, fr2, fr3 }, { fr3, fr2, fr_zero } };
const fr_t v1[3] = { fr_one, fr2, fr3 };
const fr_t v2[3] = { fr3, fr2, fr_zero };
const fr_t* vectors[2] = { v1, v2 };
fr_t scalars[2] = { fr_zero, fr_one };
fr_vector_lincomb(out, (fr_t*)vectors, (fr_t*)scalars, n, m);
fr_vector_lincomb(out, vectors, (fr_t*)scalars, n, m);
for (i = 0; i < m; i++) {
TEST_CHECK(fr_equal(&out[i], &vectors[1][i]));
}
scalars[0] = fr_one; scalars[1] = fr_zero;
fr_vector_lincomb(out, (fr_t*)vectors, (fr_t*)scalars, n, m);
fr_vector_lincomb(out, vectors, (fr_t*)scalars, n, m);
for (i = 0; i < m; i++) {
TEST_CHECK(fr_equal(&out[i], &vectors[0][i]));
}
scalars[1] = fr_one;
fr_vector_lincomb(out, (fr_t*)vectors, (fr_t*)scalars, n, m);
fr_vector_lincomb(out, vectors, (fr_t*)scalars, n, m);
for (i = 0; i < m; i++) {
fr_add(&tmp, &vectors[0][i], &vectors[1][i]);
TEST_CHECK(fr_equal(&out[i], &tmp));