From 60d8402e193f82c1af06e6852732998676db2da7 Mon Sep 17 00:00:00 2001 From: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Thu, 30 Mar 2023 16:34:55 -0500 Subject: [PATCH] Fix some nodejs nits (#271) --- .github/workflows/nodejs-tests.yml | 2 +- bindings/node.js/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs-tests.yml b/.github/workflows/nodejs-tests.yml index d67bc5a..871b53e 100644 --- a/.github/workflows/nodejs-tests.yml +++ b/.github/workflows/nodejs-tests.yml @@ -8,7 +8,7 @@ on: - main jobs: - test: + tests: runs-on: ${{matrix.os}} strategy: matrix: diff --git a/bindings/node.js/Makefile b/bindings/node.js/Makefile index c4cb44f..2431e69 100644 --- a/bindings/node.js/Makefile +++ b/bindings/node.js/Makefile @@ -1,4 +1,4 @@ -# For a less verbose yarn. +# For a less verbose yarn YARN = yarn --silent .PHONY: all @@ -73,7 +73,7 @@ publish: build bundle # Run ref-tests in linux environment for cross-compatability check .PHONY: linux-test linux-test: build - # Docker cannot copy from outside this dir + @# Docker cannot copy from outside this dir @cp -r ../../tests ref-tests @docker build -t "linux-test" . @docker logs --follow `docker run -d linux-test`