status-im
/
c-kzg-4844
mirror of https://github.com/status-im/c-kzg-4844.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #59 from jtraglia/nodejs-blob-to-comm-ret 

Check ret of blob_to_kzg_commitment in nodejs bindings
This commit is contained in:
Ramana Kumar 2023-01-10 20:45:14 -08:00 committed by GitHub
parent 7f4a8f0934 57a9666f93
commit 45c4d3d3f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bindings/node.js/kzg.cxx
View File

@ -142,7 +142,12 @@ Napi::Value BlobToKzgCommitment(const Napi::CallbackInfo& info) {
auto kzg_settings = info[1].As<Napi::External<KZGSettings>>().Data();
KZGCommitment commitment;
blob_to_kzg_commitment(&commitment, blob, kzg_settings);
C_KZG_RET ret = blob_to_kzg_commitment(&commitment, blob, kzg_settings);
if (ret != C_KZG_OK) {
Napi::Error::New(env, "Failed to convert blob to commitment")
.ThrowAsJavaScriptException();
return env.Undefined();
};
uint8_t commitment_bytes[BYTES_PER_COMMITMENT];
bytes_from_g1(commitment_bytes, &commitment);
@ -203,7 +208,7 @@ Napi::Value VerifyAggregateKzgProof(const Napi::CallbackInfo& info) {
}
auto blobs_param = info[0].As<Napi::Array>();
auto comittments_param = info[1].As<Napi::Array>();
auto commitments_param = info[1].As<Napi::Array>();
auto proof_param = info[2].As<Napi::TypedArray>();
auto kzg_settings = info[3].As<Napi::External<KZGSettings>>().Data();
@ -223,7 +228,7 @@ Napi::Value VerifyAggregateKzgProof(const Napi::CallbackInfo& info) {
memcpy(blobs[blob_index], blob_bytes, BYTES_PER_BLOB);
// Extract a G1 point for each commitment
Napi::Value commitment = comittments_param[blob_index];
Napi::Value commitment = commitments_param[blob_index];
auto commitment_bytes = commitment.As<Napi::Uint8Array>().Data();
ret = bytes_to_g1(&commitments[blob_index], commitment_bytes);