From 1493f2bf2fce6b61f654a314a4ba136fd3b7a277 Mon Sep 17 00:00:00 2001 From: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Mon, 13 Feb 2023 01:14:09 -0600 Subject: [PATCH] Fix rust bindings benchmarks (#132) --- bindings/rust/benches/kzg_benches.rs | 10 +++++++--- bindings/rust/src/lib.rs | 12 ++---------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/bindings/rust/benches/kzg_benches.rs b/bindings/rust/benches/kzg_benches.rs index ac3564a..27cc04b 100644 --- a/bindings/rust/benches/kzg_benches.rs +++ b/bindings/rust/benches/kzg_benches.rs @@ -40,10 +40,10 @@ pub fn criterion_benchmark(c: &mut Criterion) { |b, blobs| b.iter(|| KZGProof::compute_aggregate_kzg_proof(blobs, &kzg_settings)), ); - let kzg_commitments: Vec = blobs + let kzg_commitments: Vec = blobs .clone() .into_iter() - .map(|blob| KZGCommitment::blob_to_kzg_commitment(blob, &kzg_settings)) + .map(|blob| KZGCommitment::blob_to_kzg_commitment(blob, &kzg_settings).to_bytes()) .collect(); let proof = KZGProof::compute_aggregate_kzg_proof(&blobs, &kzg_settings).unwrap(); @@ -53,7 +53,11 @@ pub fn criterion_benchmark(c: &mut Criterion) { |b, blobs| { b.iter(|| { proof - .verify_aggregate_kzg_proof(&blobs, &kzg_commitments, &kzg_settings) + .verify_aggregate_kzg_proof( + &blobs, + kzg_commitments.as_slice(), + &kzg_settings, + ) .unwrap() }) }, diff --git a/bindings/rust/src/lib.rs b/bindings/rust/src/lib.rs index ae3979e..68f7d77 100644 --- a/bindings/rust/src/lib.rs +++ b/bindings/rust/src/lib.rs @@ -434,10 +434,7 @@ mod tests { for (i, blob) in blobs.into_iter().enumerate() { let commitment = KZGCommitment::blob_to_kzg_commitment(blob, &kzg_settings); - assert_eq!( - commitment.as_hex_string().as_str(), - expected_commitments[i] - ); + assert_eq!(commitment.as_hex_string().as_str(), expected_commitments[i]); } } } @@ -468,12 +465,7 @@ mod tests { let y_bytes = Bytes32::from_bytes(&hex::decode(y_hex).unwrap()).unwrap(); assert!(kzg_proof - .verify_kzg_proof( - commitment, - z_bytes, - y_bytes, - &kzg_settings - ) + .verify_kzg_proof(commitment, z_bytes, y_bytes, &kzg_settings) .unwrap()); } }